From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11837CD4F35 for ; Fri, 22 Sep 2023 09:04:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Coq0nLx8cq7h372pYzir5EuFk6k5gnR/VSj69WjRXNE=; b=2e1SaCxW5Qe/tJ JDT9Wks4lU6nCeiV8n9G8Ht6VPjufve0R4jhK8mYSK4sutXllFqsVUDOWf0ShJdP8Wv6CY/7TWudd CDZ7EHpcbH55QRcyN1z6fYYTGRHZTOVjFSEEkrSKeDPVvkZ0XoiphUdnlxe0ClikyzXLn358OW0WN eJ7Vw5eOzqwogZkCIBJ9XiUeKohDuiHbp8PXAvfT/LPDPCflowPskgoS4amlWZGdNaN6tF+RSK6iM c7cEZY1/Qa+hEVzOHe8HPH7vTfttQaqFbHoyY515eFoZ0yxdIY/jej5QkPomvWw1jY9XZ5Xw64MpW fj9gH3fSCkXahwUeWCig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qjc4V-008Uqg-2a; Fri, 22 Sep 2023 09:03:35 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qjc4Q-008UpQ-0u for linux-arm-kernel@lists.infradead.org; Fri, 22 Sep 2023 09:03:32 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 73BE96221F; Fri, 22 Sep 2023 09:03:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18462C433C7; Fri, 22 Sep 2023 09:03:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695373408; bh=VxDh6zlUkPlWGqASD5pZQ2AZHV1SUFg3JBNsX74h6z0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=BsUFrPIAY1OS1Zfdp8N3eq0cRMTskTJVk/XIo9c+h0Ccn+PHuhFmWxlFmglMYVHsL 2QQgtK9xlJf6zT6sZNVbzntL/2r2iCHufg+F2LcP+pGBEISHxpaqmQcjhDpUx/6wGT wvGrd/8tOJy0QSyi3cvZ4bPPNEq9P7yr4rWEHg5grSxcvoauZDeDbjLfzt7hqGCkhb sWVvbByGw3Bya/UHZRS0XC4rZedzy74ivqV7GezYNNFyTp63WY4a0K7Fu/s5Ur6Ts4 EFaN3HTh6dVNWtOrFFaNW6ZASn68UaL9zzMwjelyc0285pBkFx6PDibfcZoSp2DjJQ IU7E7zp/xFVUQ== Message-ID: <3eef2d49-d13e-40cf-a633-94b52948b065@kernel.org> Date: Fri, 22 Sep 2023 12:03:23 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: ti: am642-evm: Add overlay for NAND expansion card To: Andrew Davis , Nishanth Menon , Tony Lindgren , Rob Herring , david@gibson.dropbear.id.au Cc: vigneshr@ti.com, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, srk@ti.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Siddharth Vadapalli References: <20230920133450.54226-1-rogerq@kernel.org> <20230920133450.54226-3-rogerq@kernel.org> <20230920135802.3ej2wcuaruqjidel@uncouth> <20230920164424.rrjvm6nvtv4ysyrw@unreal> <6f2b38f8-1962-46f2-a095-b1eaf99ed407@kernel.org> Content-Language: en-US From: Roger Quadros In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230922_020330_433184_F54B1C6A X-CRM114-Status: GOOD ( 29.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAyMS8wOS8yMDIzIDIwOjIzLCBBbmRyZXcgRGF2aXMgd3JvdGU6Cj4gT24gOS8yMS8yMyA2 OjM3IEFNLCBSb2dlciBRdWFkcm9zIHdyb3RlOgo+PiBPbiAyMC8wOS8yMDIzIDIwOjA2LCBBbmRy ZXcgRGF2aXMgd3JvdGU6Cj4+PiBPbiA5LzIwLzIzIDExOjQ0IEFNLCBOaXNoYW50aCBNZW5vbiB3 cm90ZToKPj4+PiBPbiAxODoxOC0yMDIzMDkyMCwgUm9nZXIgUXVhZHJvcyB3cm90ZToKPj4+Pj4K Pj4+Pj4KPj4+Pj4gT24gMjAvMDkvMjAyMyAxNjo1OCwgTmlzaGFudGggTWVub24gd3JvdGU6Cj4+ Pj4+PiBPbiAxNjozNC0yMDIzMDkyMCwgUm9nZXIgUXVhZHJvcyB3cm90ZToKPj4+Pj4+PiBUaGUg TkFORCBleHBhbnNpb24gY2FyZCBwbHVncyBpbiBvdmVyIHRoZSBIU0UgKEhpZ2ggU3BlZWQgRXhw YW5zaW9uKQo+Pj4+Pj4+IGNvbm5lY3Rvci4gQWRkIHN1cHBvcnQgZm9yIGl0Lgo+Pj4+Pj4+Cj4+ Pj4+Pj4gU2lnbmVkLW9mZi1ieTogUm9nZXIgUXVhZHJvcyA8cm9nZXJxQGtlcm5lbC5vcmc+Cj4+ Pj4+Pj4gLS0tCj4+Pj4+Pj4gwqDCoCBhcmNoL2FybTY0L2Jvb3QvZHRzL3RpL01ha2VmaWxlwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8wqDCoCAxICsKPj4+Pj4+PiDCoMKgIGFyY2gvYXJt NjQvYm9vdC9kdHMvdGkvazMtYW02NDItZXZtLW5hbmQuZHRzbyB8IDE0MCArKysrKysrKysrKysr KysrKysKPj4+Pj4+PiDCoMKgIDIgZmlsZXMgY2hhbmdlZCwgMTQxIGluc2VydGlvbnMoKykKPj4+ Pj4+PiDCoMKgIGNyZWF0ZSBtb2RlIDEwMDY0NCBhcmNoL2FybTY0L2Jvb3QvZHRzL3RpL2szLWFt NjQyLWV2bS1uYW5kLmR0c28KPj4+Pj4+Pgo+Pj4+Pj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybTY0 L2Jvb3QvZHRzL3RpL01ha2VmaWxlIGIvYXJjaC9hcm02NC9ib290L2R0cy90aS9NYWtlZmlsZQo+ Pj4+Pj4+IGluZGV4IDA2ZDZmMjY0ZjI5Mi4uZWNlNzQwODVhNmJlIDEwMDY0NAo+Pj4+Pj4+IC0t LSBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvdGkvTWFrZWZpbGUKPj4+Pj4+PiArKysgYi9hcmNoL2Fy bTY0L2Jvb3QvZHRzL3RpL01ha2VmaWxlCj4+Pj4+Pj4gQEAgLTI5LDYgKzI5LDcgQEAgZHRiLSQo Q09ORklHX0FSQ0hfSzMpICs9IGszLWFtNjJwNS1zay5kdGIKPj4+Pj4+PiDCoMKgIMKgICMgQm9h cmRzIHdpdGggQU02NHggU29DCj4+Pj4+Pj4gwqDCoCBkdGItJChDT05GSUdfQVJDSF9LMykgKz0g azMtYW02NDItZXZtLmR0Ygo+Pj4+Pj4+ICtkdGItJChDT05GSUdfQVJDSF9LMykgKz0gazMtYW02 NDItZXZtLW5hbmQuZHRibwo+Pj4+Pj4+IMKgwqAgZHRiLSQoQ09ORklHX0FSQ0hfSzMpICs9IGsz LWFtNjQyLXBoeWJvYXJkLWVsZWN0cmEtcmRrLmR0Ygo+Pj4+Pj4+IMKgwqAgZHRiLSQoQ09ORklH X0FSQ0hfSzMpICs9IGszLWFtNjQyLXNrLmR0Ygo+Pj4+Pj4+IMKgwqAgZHRiLSQoQ09ORklHX0FS Q0hfSzMpICs9IGszLWFtNjQyLXRxbWE2NHh4bC1tYmF4NHh4bC5kdGIKPj4+Pj4+Cj4+Pj4+PiBB bHNvIHNlZSBodHRwczovL2xvcmUua2VybmVsLm9yZy9hbGwvMjAyMzA5MTExNjU2MTAuR0ExMzYy OTMyLXJvYmhAa2VybmVsLm9yZy8KPj4+Pj4+Cj4+Pj4+PiB5b3UgbWF5IG5vdCBnZXQgdGhlIGR0 Ym8gaW5zdGFsbGVkIHdoZW4gZG9pbmcgbWFrZSBkdGJzX2luc3RhbGwKPj4+Pj4+Cj4+Pj4+PiBb Li4uXQo+Pj4+Pj4KPj4+Pj4KPj4+Pj4gJCB2OG1ha2UgZHRic19pbnN0YWxsIElOU1RBTExfRFRC U19QQVRIPS90bXAKPj4+Pj4gwqDCoMKgIElOU1RBTEwgL3RtcC90aS9rMy1hbTYyNS1iZWFnbGVw bGF5LmR0Ygo+Pj4+PiDCoMKgwqAgSU5TVEFMTCAvdG1wL3RpL2szLWFtNjI1LXBoeWJvYXJkLWx5 cmEtcmRrLmR0Ygo+Pj4+PiDCoMKgwqAgSU5TVEFMTCAvdG1wL3RpL2szLWFtNjI1LXNrLmR0Ygo+ Pj4+PiDCoMKgwqAgSU5TVEFMTCAvdG1wL3RpL2szLWFtNjI1LXZlcmRpbi1ub253aWZpLWRhaGxp YS5kdGIKPj4+Pj4gwqDCoMKgIElOU1RBTEwgL3RtcC90aS9rMy1hbTYyNS12ZXJkaW4tbm9ud2lm aS1kZXYuZHRiCj4+Pj4+IMKgwqDCoCBJTlNUQUxMIC90bXAvdGkvazMtYW02MjUtdmVyZGluLW5v bndpZmkteWF2aWEuZHRiCj4+Pj4+IMKgwqDCoCBJTlNUQUxMIC90bXAvdGkvazMtYW02MjUtdmVy ZGluLXdpZmktZGFobGlhLmR0Ygo+Pj4+PiDCoMKgwqAgSU5TVEFMTCAvdG1wL3RpL2szLWFtNjI1 LXZlcmRpbi13aWZpLWRldi5kdGIKPj4+Pj4gwqDCoMKgIElOU1RBTEwgL3RtcC90aS9rMy1hbTYy NS12ZXJkaW4td2lmaS15YXZpYS5kdGIKPj4+Pj4gwqDCoMKgIElOU1RBTEwgL3RtcC90aS9rMy1h bTYyLWxwLXNrLmR0Ygo+Pj4+PiDCoMKgwqAgSU5TVEFMTCAvdG1wL3RpL2szLWFtNjJ4LXNrLWhk bWktYXVkaW8uZHRibwo+Pj4+PiDCoMKgwqAgSU5TVEFMTCAvdG1wL3RpL2szLWFtNjJhNy1zay5k dGIKPj4+Pj4gwqDCoMKgIElOU1RBTEwgL3RtcC90aS9rMy1hbTYycDUtc2suZHRiCj4+Pj4+IMKg wqDCoCBJTlNUQUxMIC90bXAvdGkvazMtYW02NDItZXZtLmR0Ygo+Pj4+PiDCoMKgwqAgSU5TVEFM TCAvdG1wL3RpL2szLWFtNjQyLWV2bS1uYW5kLmR0Ym8KPj4+Pj4gXl5eXgo+Pj4+PiDCoMKgwqAg SU5TVEFMTCAvdG1wL3RpL2szLWFtNjQyLXBoeWJvYXJkLWVsZWN0cmEtcmRrLmR0Ygo+Pj4+PiDC oMKgwqAgSU5TVEFMTCAvdG1wL3RpL2szLWFtNjQyLXNrLmR0Ygo+Pj4+Pgo+Pj4+Pgo+Pj4+PiBX aGF0IGRpZCBJIG1pc3M/Cj4+Pj4KPj4+PiBJIG1pc3NlZCBpdCwgYWN0dWFsbHkuIFNlZSBSb2In cyBjb21tZW50Ogo+Pj4+IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2FsbC9DQUxfSnNxK0dSM2hQ NmhGdkZuMno1YVh2U1huaDlidXREM2FLWi15X1hKZ3gwX1lQVHdAbWFpbC5nbWFpbC5jb20vCj4+ Pj4KPj4+PiBIYXZpbmcgb3JwaGFuIGR0Ym8gaXMgYXBwYXJlbnRseSBmcm93bmVkIHVwb24KPj4+ Pgo+Pj4KPj4+IEFuZCBpZiB5b3UgYXBwbHkgdGhlc2Ugb3ZlcmxheXMgdG8gdGhlIGJhc2UgRFRC IHRoZW4gaXQgZ2V0cwo+Pj4gc3ltYm9scyBhZGRlZCBhdXRvbWF0aWNhbGx5LCBubyBuZWVkIGZv ciB5b3VyIHBhdGNoIFsxLzJdIGhlcmUuCj4+Pgo+Pgo+PiBJcyB0aGlzIE9LPwo+Pgo+PiDCoMKg wqDCoGszLWFtNjQyLWV2bS1uYW5kLWR0YnMgOj0gazMtYW02NDItZXZtLmR0YiBrMy1hbTY0Mi1l dm0tbmFuZC5kdGJvCj4+IMKgwqDCoMKgZHRiLSQoQ09ORklHX0FSQ0hfSzMpICs9IGszLWFtNjQy LWV2bS1uYW5kLmR0Ygo+Pgo+PiBTbyBwYXRjaCAxIGlzIG5vdCByZXF1aXJlZCBpbiB0aGlzIGNh c2UgYnV0IHdlIGhhdmUgYW4KPj4gZXh0cmEgZHRiIGZpbGUgd2hpY2ggaXMgbm90IHJlYWxseSBy ZXF1aXJlZC4KPj4KPiAKPiBXaGlsZSBJIGFncmVlIHdlIHdpbGwgZW5kIHVwIHdpdGggc2V2ZXJh bCBwcmUtb3ZlcmxheWVkIERUQiBmaWxlcwo+IHRoYXQgYXJlIGFyZ3VhYmx5IG5vdCByZXF1aXJl ZCBhcyB0aGV5IGNvdWxkIGJlIGxhdGVyIGJ1aWx0L2FwcGxpZWQsCj4gdW50aWwgd2UgZmluZCBh IGJldHRlciB3YXkgdG8gY2hlY2sgYXQgYnVpbGQgdGltZSB0aGVzZSBvdmVybGF5cwo+IG5lZWQg YXBwbGllZCB0byBzb21ldGhpbmcgYXMgYSB0ZXN0Lgo+IAo+PiBJIGhhdmUgMiBtb3JlIGlzc3Vl cyB0byBwb2ludCBvdXQKPj4KPj4gMSkKPj4gV2l0aCBleGlzdGluZyBleGFtcGxlcyBlLmcuIEo3 MjAwIEVWTQo+PiB3b3VsZG4ndMKgIGszLWo3MjAwLWV2bS5kdGIgaW5jbHVkZSB0aGUgazMtajcy MDAtZXZtLXF1YWQtcG9ydC1ldGgtZXhwLmR0Ym8/Cj4+IElzIHRoaXMgd2hhdCB3ZSByZWFsbHkg d2FudD8KPj4KPj4gbGlrZXdpc2UgZm9yIGszLWo3MjFlLWV2bS5kdGIgYW5kIGszLWFtNjU0LWdw LWV2bS5kdGIKPj4KPiAKPiBZZXMsIHRoYXQgaXMgdGhlIGlkZWEsIHRoZSBiYXNlLWJvYXJkLmR0 YiBpcyBqdXN0IHRoZSByYXcgbWFpbiBib2FyZCwgYnV0Cj4gdGhlICJFVk0iIHdoZW4geW91IGJ1 eSBpdCBjb21lcyB3aXRoIHRoZSBxdWFkLXBvcnQgZGF1Z2h0ZXJjYXJkIGF0dGFjaGVkLgo+IFRo YXQgaXMgd2hhdCB3ZSBjb25zaWRlciB0aGUgIkVWTSIgYW5kIHRoZSBEVEIgbmFtZXMgbWF0Y2gg dGhhdC4KPiAKPj4gMikKPj4gQW5vdGhlciBpc3N1ZSAodW5yZWxhdGVkIHRvIHRoaXMgY2hhbmdl KSBpcyB0aGUgYmVsb3cgd2FybmluZzoKPj4KPj4gwqDCoMKgwqBhcmNoL2FybTY0L2Jvb3QvZHRz L3RpL2szLWFtNjQyLWV2bS1uYW5kLmR0c286NjUuOC0xNDAuMzogV2FybmluZyAoYXZvaWRfZGVm YXVsdF9hZGRyX3NpemUpOiAvZnJhZ21lbnRAMy9fX292ZXJsYXlfXzogUmVseWluZyBvbiBkZWZh dWx0ICNhZGRyZXNzLWNlbGxzIHZhbHVlCj4+IMKgwqDCoMKgYXJjaC9hcm02NC9ib290L2R0cy90 aS9rMy1hbTY0Mi1ldm0tbmFuZC5kdHNvOjY1LjgtMTQwLjM6IFdhcm5pbmcgKGF2b2lkX2RlZmF1 bHRfYWRkcl9zaXplKTogL2ZyYWdtZW50QDMvX19vdmVybGF5X186IFJlbHlpbmcgb24gZGVmYXVs dCAjc2l6ZS1jZWxscyB2YWx1ZQo+Pgo+PiBUaGlzIGlzIGJlY2F1c2Ugd2UgdXNlIHRoZSAncmFu Z2VzJyBwcm9wZXJ0eSBpbiB0aGUgZ3BtYzAgbm9kZQo+PiBhbmQgdGhlIGNvbXBpbGVyIGRvZXNu J3Qga25vdyB0aGUgI2FkZHJlc3Mvc2l6ZS1jZWxscyBvZiB0aGUKPj4gcGFyZW50IG5vZGUuCj4+ Cj4+IElzIHRoZXJlIGEgdHJpY2sgdG8gc3BlY2lmeSBpdCBpbiB0aGUgZHRzbyBmaWxlPwo+Pgo+ IAo+IEhtbSwgc2VlbXMgbGlrZSBhIHRyaWNreSBvbmUuIERvIHlvdSByZWFsbHkgbmVlZCB0byBk byB0aGUgcmFuZ2VzIGhlcmU/Cj4gQ291bGQgeW91IHVzZSB0aGUgZGVmYXVsdCBgcmFuZ2VzO2Ag Zm9yIGdwbWMwPyBUaGVuIGRvIHRoZSByYW5nZSB0cmFuc2xhdGlvbgo+IGRvd24gaW5zaWRlIHRo ZSBuYW5kIG5vZGUgdG8ga2VlcCB0aGUgcGFydGl0aW9uIGFkZHJlc3NlcyBzYW5lLgoKR1BNQyBo YXMgc2VwYXJhdGUgYWRkcmVzcyBzcGFjZXMgcGVyIGNoaXAgc2VsZWN0LiAKCkZyb20gRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL21lbW9yeS1jb250cm9sbGVycy90aSxncG1jLnlh bWwKICByYW5nZXM6CiAgICBtaW5JdGVtczogMQogICAgZGVzY3JpcHRpb246IHwKICAgICAgTXVz dCBiZSBzZXQgdXAgdG8gcmVmbGVjdCB0aGUgbWVtb3J5IGxheW91dCB3aXRoIGZvdXIKICAgICAg aW50ZWdlciB2YWx1ZXMgZm9yIGVhY2ggY2hpcC1zZWxlY3QgbGluZSBpbiB1c2UsCiAgICAgIDxj cy1udW1iZXI+IDAgPHBoeXNpY2FsIGFkZHJlc3Mgb2YgbWFwcGluZz4gPHNpemU+CgpUaGUgcmFu Z2VzIGxvY2F0aW9uIGluIHRoZSBkZXZpY2UgdHJlZSBvdmVybGF5IGlzIGNvcnJlY3QuIFRoZSBv dmVybGF5IGlzCm1lYW5pbmdsZXNzIHdpdGhvdXQgdGhlIGJhc2UgdHJlZS4KClRoZSBjb3JyZWN0 IHNvbHV0aW9uIHdvdWxkIGJlIHRvIGZpeCBkdGMgc28gaXQgZG9lc24ndCBwcmludCB0aGlzIHdh cm5pbmcKZm9yIERUIG92ZXJsYXlzLgoKaS5lLgoKZGlmZiAtLWdpdCBhL3NjcmlwdHMvZHRjL2No ZWNrcy5jIGIvc2NyaXB0cy9kdGMvY2hlY2tzLmMKaW5kZXggOWYzMWQyNjA3MTgyLi5kY2IwYTZm NmYzZmIgMTAwNjQ0Ci0tLSBhL3NjcmlwdHMvZHRjL2NoZWNrcy5jCisrKyBiL3NjcmlwdHMvZHRj L2NoZWNrcy5jCkBAIC0xMjAzLDYgKzEyMDMsOSBAQCBzdGF0aWMgdm9pZCBjaGVja19hdm9pZF9k ZWZhdWx0X2FkZHJfc2l6ZShzdHJ1Y3QgY2hlY2sgKmMsIHN0cnVjdCBkdF9pbmZvICpkdGksCiAg ICAgICAgaWYgKCFyZWcgJiYgIXJhbmdlcykKICAgICAgICAgICAgICAgIHJldHVybjsKIAorICAg ICAgIGlmIChzdHJlcShub2RlLT5uYW1lLCAiX19vdmVybGF5X18iKSkKKyAgICAgICAgICAgICAg IHJldHVybjsKKwogICAgICAgIGlmIChub2RlLT5wYXJlbnQtPmFkZHJfY2VsbHMgPT0gLTEpCiAg ICAgICAgICAgICAgICBGQUlMKGMsIGR0aSwgbm9kZSwgIlJlbHlpbmcgb24gZGVmYXVsdCAjYWRk cmVzcy1jZWxscyB2YWx1ZSIpOwoKCi0tIApjaGVlcnMsCi1yb2dlcgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7448C4419 for ; Fri, 22 Sep 2023 09:03:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18462C433C7; Fri, 22 Sep 2023 09:03:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695373408; bh=VxDh6zlUkPlWGqASD5pZQ2AZHV1SUFg3JBNsX74h6z0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=BsUFrPIAY1OS1Zfdp8N3eq0cRMTskTJVk/XIo9c+h0Ccn+PHuhFmWxlFmglMYVHsL 2QQgtK9xlJf6zT6sZNVbzntL/2r2iCHufg+F2LcP+pGBEISHxpaqmQcjhDpUx/6wGT wvGrd/8tOJy0QSyi3cvZ4bPPNEq9P7yr4rWEHg5grSxcvoauZDeDbjLfzt7hqGCkhb sWVvbByGw3Bya/UHZRS0XC4rZedzy74ivqV7GezYNNFyTp63WY4a0K7Fu/s5Ur6Ts4 EFaN3HTh6dVNWtOrFFaNW6ZASn68UaL9zzMwjelyc0285pBkFx6PDibfcZoSp2DjJQ IU7E7zp/xFVUQ== Message-ID: <3eef2d49-d13e-40cf-a633-94b52948b065@kernel.org> Date: Fri, 22 Sep 2023 12:03:23 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: ti: am642-evm: Add overlay for NAND expansion card To: Andrew Davis , Nishanth Menon , Tony Lindgren , Rob Herring , david@gibson.dropbear.id.au Cc: vigneshr@ti.com, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, srk@ti.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Siddharth Vadapalli References: <20230920133450.54226-1-rogerq@kernel.org> <20230920133450.54226-3-rogerq@kernel.org> <20230920135802.3ej2wcuaruqjidel@uncouth> <20230920164424.rrjvm6nvtv4ysyrw@unreal> <6f2b38f8-1962-46f2-a095-b1eaf99ed407@kernel.org> Content-Language: en-US From: Roger Quadros In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 21/09/2023 20:23, Andrew Davis wrote: > On 9/21/23 6:37 AM, Roger Quadros wrote: >> On 20/09/2023 20:06, Andrew Davis wrote: >>> On 9/20/23 11:44 AM, Nishanth Menon wrote: >>>> On 18:18-20230920, Roger Quadros wrote: >>>>> >>>>> >>>>> On 20/09/2023 16:58, Nishanth Menon wrote: >>>>>> On 16:34-20230920, Roger Quadros wrote: >>>>>>> The NAND expansion card plugs in over the HSE (High Speed Expansion) >>>>>>> connector. Add support for it. >>>>>>> >>>>>>> Signed-off-by: Roger Quadros >>>>>>> --- >>>>>>>    arch/arm64/boot/dts/ti/Makefile               |   1 + >>>>>>>    arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso | 140 ++++++++++++++++++ >>>>>>>    2 files changed, 141 insertions(+) >>>>>>>    create mode 100644 arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso >>>>>>> >>>>>>> diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile >>>>>>> index 06d6f264f292..ece74085a6be 100644 >>>>>>> --- a/arch/arm64/boot/dts/ti/Makefile >>>>>>> +++ b/arch/arm64/boot/dts/ti/Makefile >>>>>>> @@ -29,6 +29,7 @@ dtb-$(CONFIG_ARCH_K3) += k3-am62p5-sk.dtb >>>>>>>      # Boards with AM64x SoC >>>>>>>    dtb-$(CONFIG_ARCH_K3) += k3-am642-evm.dtb >>>>>>> +dtb-$(CONFIG_ARCH_K3) += k3-am642-evm-nand.dtbo >>>>>>>    dtb-$(CONFIG_ARCH_K3) += k3-am642-phyboard-electra-rdk.dtb >>>>>>>    dtb-$(CONFIG_ARCH_K3) += k3-am642-sk.dtb >>>>>>>    dtb-$(CONFIG_ARCH_K3) += k3-am642-tqma64xxl-mbax4xxl.dtb >>>>>> >>>>>> Also see https://lore.kernel.org/all/20230911165610.GA1362932-robh@kernel.org/ >>>>>> >>>>>> you may not get the dtbo installed when doing make dtbs_install >>>>>> >>>>>> [...] >>>>>> >>>>> >>>>> $ v8make dtbs_install INSTALL_DTBS_PATH=/tmp >>>>>     INSTALL /tmp/ti/k3-am625-beagleplay.dtb >>>>>     INSTALL /tmp/ti/k3-am625-phyboard-lyra-rdk.dtb >>>>>     INSTALL /tmp/ti/k3-am625-sk.dtb >>>>>     INSTALL /tmp/ti/k3-am625-verdin-nonwifi-dahlia.dtb >>>>>     INSTALL /tmp/ti/k3-am625-verdin-nonwifi-dev.dtb >>>>>     INSTALL /tmp/ti/k3-am625-verdin-nonwifi-yavia.dtb >>>>>     INSTALL /tmp/ti/k3-am625-verdin-wifi-dahlia.dtb >>>>>     INSTALL /tmp/ti/k3-am625-verdin-wifi-dev.dtb >>>>>     INSTALL /tmp/ti/k3-am625-verdin-wifi-yavia.dtb >>>>>     INSTALL /tmp/ti/k3-am62-lp-sk.dtb >>>>>     INSTALL /tmp/ti/k3-am62x-sk-hdmi-audio.dtbo >>>>>     INSTALL /tmp/ti/k3-am62a7-sk.dtb >>>>>     INSTALL /tmp/ti/k3-am62p5-sk.dtb >>>>>     INSTALL /tmp/ti/k3-am642-evm.dtb >>>>>     INSTALL /tmp/ti/k3-am642-evm-nand.dtbo >>>>> ^^^^ >>>>>     INSTALL /tmp/ti/k3-am642-phyboard-electra-rdk.dtb >>>>>     INSTALL /tmp/ti/k3-am642-sk.dtb >>>>> >>>>> >>>>> What did I miss? >>>> >>>> I missed it, actually. See Rob's comment: >>>> https://lore.kernel.org/all/CAL_Jsq+GR3hP6hFvFn2z5aXvSXnh9butD3aKZ-y_XJgx0_YPTw@mail.gmail.com/ >>>> >>>> Having orphan dtbo is apparently frowned upon >>>> >>> >>> And if you apply these overlays to the base DTB then it gets >>> symbols added automatically, no need for your patch [1/2] here. >>> >> >> Is this OK? >> >>     k3-am642-evm-nand-dtbs := k3-am642-evm.dtb k3-am642-evm-nand.dtbo >>     dtb-$(CONFIG_ARCH_K3) += k3-am642-evm-nand.dtb >> >> So patch 1 is not required in this case but we have an >> extra dtb file which is not really required. >> > > While I agree we will end up with several pre-overlayed DTB files > that are arguably not required as they could be later built/applied, > until we find a better way to check at build time these overlays > need applied to something as a test. > >> I have 2 more issues to point out >> >> 1) >> With existing examples e.g. J7200 EVM >> wouldn't  k3-j7200-evm.dtb include the k3-j7200-evm-quad-port-eth-exp.dtbo? >> Is this what we really want? >> >> likewise for k3-j721e-evm.dtb and k3-am654-gp-evm.dtb >> > > Yes, that is the idea, the base-board.dtb is just the raw main board, but > the "EVM" when you buy it comes with the quad-port daughtercard attached. > That is what we consider the "EVM" and the DTB names match that. > >> 2) >> Another issue (unrelated to this change) is the below warning: >> >>     arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso:65.8-140.3: Warning (avoid_default_addr_size): /fragment@3/__overlay__: Relying on default #address-cells value >>     arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso:65.8-140.3: Warning (avoid_default_addr_size): /fragment@3/__overlay__: Relying on default #size-cells value >> >> This is because we use the 'ranges' property in the gpmc0 node >> and the compiler doesn't know the #address/size-cells of the >> parent node. >> >> Is there a trick to specify it in the dtso file? >> > > Hmm, seems like a tricky one. Do you really need to do the ranges here? > Could you use the default `ranges;` for gpmc0? Then do the range translation > down inside the nand node to keep the partition addresses sane. GPMC has separate address spaces per chip select. >From Documentation/devicetree/bindings/memory-controllers/ti,gpmc.yaml ranges: minItems: 1 description: | Must be set up to reflect the memory layout with four integer values for each chip-select line in use, 0 The ranges location in the device tree overlay is correct. The overlay is meaningless without the base tree. The correct solution would be to fix dtc so it doesn't print this warning for DT overlays. i.e. diff --git a/scripts/dtc/checks.c b/scripts/dtc/checks.c index 9f31d2607182..dcb0a6f6f3fb 100644 --- a/scripts/dtc/checks.c +++ b/scripts/dtc/checks.c @@ -1203,6 +1203,9 @@ static void check_avoid_default_addr_size(struct check *c, struct dt_info *dti, if (!reg && !ranges) return; + if (streq(node->name, "__overlay__")) + return; + if (node->parent->addr_cells == -1) FAIL(c, dti, node, "Relying on default #address-cells value"); -- cheers, -roger