From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EDF7C3600C for ; Tue, 8 Apr 2025 09:20:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B18D6B0007; Tue, 8 Apr 2025 05:20:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05E696B0008; Tue, 8 Apr 2025 05:20:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E68126B000A; Tue, 8 Apr 2025 05:20:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C9CD26B0007 for ; Tue, 8 Apr 2025 05:20:12 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2594458BB2 for ; Tue, 8 Apr 2025 09:20:13 +0000 (UTC) X-FDA: 83310330306.17.C85EDFC Received: from server4.hayhost.am (server4.hayhost.am [2.56.206.6]) by imf14.hostedemail.com (Postfix) with ESMTP id B108E100011 for ; Tue, 8 Apr 2025 09:20:09 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=beldev.am header.s=default header.b="GVPQta/d"; dmarc=pass (policy=none) header.from=beldev.am; spf=pass (imf14.hostedemail.com: domain of igor.b@beldev.am designates 2.56.206.6 as permitted sender) smtp.mailfrom=igor.b@beldev.am ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744104010; a=rsa-sha256; cv=none; b=7tuvZhObBreEUSH8LWg7TC7MkmqsKaSlu8QuH2rqyJ73hbpCzD3RagBar4glV2SUlkENgJ 1qBqXKw2ocVnX5k7wnW5XCAUBwl+gKFuUJ5/YG1oRAlRNF9STDhRUbZEYsBxiznQTsRgpL GkuHmNlCdawN+Xl5DxaTzv1I/Ryme2g= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=beldev.am header.s=default header.b="GVPQta/d"; dmarc=pass (policy=none) header.from=beldev.am; spf=pass (imf14.hostedemail.com: domain of igor.b@beldev.am designates 2.56.206.6 as permitted sender) smtp.mailfrom=igor.b@beldev.am ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744104010; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FAQWLddjvIhGD1mEzeXztnSrdDH1xu8SvzVV71X0s+Q=; b=d86xebHC5zPyjnYkkVjdRvk6vWKAiQISyyg5kFXDAQxZgavjBFq3nd7oOCr9RpWPNuxdAe ooq0tcSnfzEdkCx2YiYagR8IJg3xuxQlK7DxIYUUio/u4zDYIXgFpLMTh951+4CYzE4X6d X6vNxgtpi9aDacmbRehLijIYpz2jX0g= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=beldev.am; s=default; h=Content-Transfer-Encoding:Content-Type:Message-ID:References: In-Reply-To:Subject:Cc:To:From:Date:MIME-Version:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FAQWLddjvIhGD1mEzeXztnSrdDH1xu8SvzVV71X0s+Q=; b=GVPQta/duSWT/7npKbIqcotLfD rWw3Ak71SAn9sapYmxbgLQO/hwFOKp7lcfl37tYF2A33hKQ3ksQsg7OQx4rL80vnD1QflsfrJ8bxL GV+JqQaLHplrdBL6xP7dQgw5RMazLxKDAKunz7yYKr5IO2ROctl+uFrj51X+m270T2HpljIMWxrIE B/kk20YoaY96Vq6OasH90PRR0VjpiRuxbqppKqdAXlsIczyovYQgUYhhWSoJ5fAlVsY/Kg2/i/v4c dDqS9iw4u7jGn+wou3Tjy89I6x8ouCM5K8DCqe5aWcd9QpNGMM3y/6F/Ru02WQrT6y+pO9K5G9uAd loHe2L9A==; Received: from [::1] (port=60520 helo=server4.hayhost.am) by server4.hayhost.am with esmtpa (Exim 4.98.1) (envelope-from ) id 1u257t-000000005Eo-3K7b; Tue, 08 Apr 2025 13:20:13 +0400 MIME-Version: 1.0 Date: Tue, 08 Apr 2025 13:20:11 +0400 From: Igor Belousov To: Nhat Pham Cc: vitaly.wool@konsulko.se, Johannes Weiner , linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Shakeel Butt Subject: Re: [PATCH v2] mm: add zblock allocator In-Reply-To: References: <1743810988579.7.125720@webmail-backend-production-7b88b644bb-5mmj8> <0dbbbe9d17ed489d4a7dbe12026fc6fd@beldev.am> User-Agent: Roundcube Webmail/1.6.9 Message-ID: <3f013184c80e254585b56c5f16b7e778@beldev.am> X-Sender: igor.b@beldev.am Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server4.hayhost.am X-AntiAbuse: Original Domain - kvack.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - beldev.am X-Get-Message-Sender-Via: server4.hayhost.am: authenticated_id: igor.b@beldev.am X-Authenticated-Sender: server4.hayhost.am: igor.b@beldev.am X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B108E100011 X-Stat-Signature: zxjox39apbodob8cwaw8ht6xbfgfxwj8 X-HE-Tag: 1744104009-32872 X-HE-Meta: U2FsdGVkX1/D7lDn6LDRaRSNBhjkPcb7jJ/0qJoo3rHEABc6FuH7z238VlM6oQw/+l4FkNIwvrZQSOvHv5x1zrthUu0jbwBiMG6Jed4QWNtEYkaAtYdaortAygMSYLNEEKj81f6OIEAEVTPLtcB3BbLM8h2nFLCmRT+bkF7me1EJYe29KQDT47hsAjxcj0K49ObWhO4xpkNb2iGq6FVhYjwseCnEzcx30/8gHmoMheW2UjCDAJyGsRkIQcH0g7NORxfqKuMvu5J9VXdofHT0WgLnZlRKJxb6VxrI9W6hRnWbgEqjnJ9ZbldYS4BeGM/pN89HGw/xMsVgAmS2U0c2fUJRT7MSfyocQ7Uu7/O3IwZQXVyIX6Meqs7O1BTfC4ow40A6n+h4V+76uueDnhEaf6c+swFbTbL2wP8W7PVstJ7xXwrFQ0olOnYAlK7vMAyapFwn6yb8ebsU8ESCOBUphJuCLaYfkNoGpXofY0+irPZXvh7WCTZc77q/kulv6gUvl39fG+oG12dLzqZ6O+y835av5LXn3BJC0qhOxV+EGY+At9Uae5iWoSPYTvLMRQ/9urHO9adPJKRV9IFf7p9pIBmlqeZOd20w5IuQUD9wcXrKCGZEvMRGV/EOmK0JftQgWOv+BOj555U2j6KXubpBJohlz5CUwHc6Z4l0noZCPbTCGcQxC7AvHt46w4VcTSZcyXLzNunw75JWG/ybN3SieYSDCzsI1vfP9/zCjlqUcFeW7K72xFFViohKyruADwEIrO2GCUgZ1VeiHHLk+cO6gokCuqBl+6p9VWd/2+FAjuGpDRRZFEaOMkS5RMljWVH5F4qrn4YnhFJtF+iLveDdzqjfq5UWGJWuVemsaAAIR/Fnrm/8CwYUZ3ZwLuSQUvikqm064GIh4Ds++YyktzKkPCLlFzFxJU6RVNVslJbsxlHbvlNbExC56gWcBJJZEMrdQy1BxHWXW7Xnz1HuVOR /UvB8Jpk g4Ppxwc752c3/ArGiaOnWA/oxdCVydlwRXG7ErAjirvgj0+KnrXrJpfAbfCIZ0ITQzMyn70UGqq7Zv5Pae1DHa/UVRJDkKuosIZPdCmUnipWLkZOz9qYz2716XU5ECDGn9uw4wiZBvLV2+WXdZEmI6K2u06/Bac8A8ZZtnWnO/MXKb6ClMO1s3bHWH2DmQF5SAPXE3eYoaxtYcocACfMtC5K//+g4wKtS+USIRlHrf8zCCW3EjHh/IvXjihpoYs2xaEQNicrEdvu3UHl8moY0A9NwRif8RWyqNCGEzvzG68QcQgavEN/OTnP4oRRGDSvDGjm9Ne8OLql2aDo1jnOWE6TBUJwzRKhu+aeKjnz0r3rc9MoILy+ahYYAE/GzdVRxvbT8MJwWHbJnAOjmf0c7pbt4RsyvzemSWMbb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> >> >>> Do you have zswap/zswapped meminfo metrics from these tests? >> >> >> Yep, and those look somewhat similar: >> >> >> - zblock: >> >> >> Zswap: 234128 kB >> >> >> Zswapped: 733216 kB >> >> >> - zsmalloc: >> >> >> Zswap: 286080 kB >> >> >> Zswapped: 774688 kB >> >> > >> >> > I tested the kernel build on a 4-core virtual machine with allocated 4 >> >> > GB RAM running on a Ryzen 9. >> >> > >> >> > The results are the following: >> >> [...] >> >> >> >> Now what's funny is that when I tried to compare how 32 threaded build >> >> would behave on a 8-core VM I couldn't do it because it OOMs with >> >> zsmalloc as zswap backend. With zblock it doesn't, though, and the >> >> results are: >> >> real 12m14.012s >> >> user 39m37.777s >> >> sys 14m6.923s >> >> Zswap: 440148 kB >> >> Zswapped: 924452 kB >> >> zswpin 594812 >> >> zswpout 2802454 >> >> zswpwb 10878 >> >> >> >> /Igor >> > >> > May I ask what compression algorithm you are using? >> >> It's LZ4 for all the test runs. > > Can you try zstd and let me know how it goes :) Sure. zstd/8 cores/make -j32: zsmalloc: real 7m36.413s user 38m0.481s sys 7m19.108s Zswap: 211028 kB Zswapped: 925904 kB zswpin 397851 zswpout 1625707 zswpwb 5126 zblock: real 7m55.009s user 39m23.147s sys 7m44.004s Zswap: 253068 kB Zswapped: 919956 kB zswpin 456843 zswpout 2058963 zswpwb 3921 >> > And does the zswpwb come from zswap shrinker? >> >> Haven't looked into that, to be honest. > > Can you check: > > /sys/module/zswap/parameters/shrinker_enabled It's 'Y' so the answer is yes. /Igor