From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE7FDC433F5 for ; Fri, 28 Jan 2022 11:09:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244130AbiA1LJm (ORCPT ); Fri, 28 Jan 2022 06:09:42 -0500 Received: from foss.arm.com ([217.140.110.172]:36894 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348068AbiA1LJS (ORCPT ); Fri, 28 Jan 2022 06:09:18 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B86E0113E; Fri, 28 Jan 2022 03:09:17 -0800 (PST) Received: from [10.57.12.200] (unknown [10.57.12.200]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2B73A3F766; Fri, 28 Jan 2022 03:09:15 -0800 (PST) Subject: Re: [PATCH] kselftest: Fix vdso_test_abi return status To: Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Shuah Khan , Andy Lutomirski , Thomas Gleixner , Cristian Marussi References: <20220126102723.23300-3-cristian.marussi@arm.com> <20220126122608.54061-1-vincenzo.frascino@arm.com> <5ea69341-73af-e741-7b5d-c161845583c9@linuxfoundation.org> From: Vincenzo Frascino Message-ID: <3f0ed265-1eec-b12a-2fc2-6a558eb835c4@arm.com> Date: Fri, 28 Jan 2022 11:09:27 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <5ea69341-73af-e741-7b5d-c161845583c9@linuxfoundation.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Hi Shuah, On 1/27/22 11:18 PM, Shuah Khan wrote: > > You can use the ksft_* counts interfaces for this instead of adding > counts here. ksft_test_result_*() can be used to increment the right > result counters and then print counts at the end. > > Either if there is a failure in any of the tests it will be fail with > clear indication on which tests failed. vdso_test_clock() test for > example is reporting false positives by overriding the Skip return > with a pass. > Good point. I missed one condition in updating the test. I will post v2 that will be compliant with the interface you mentioned. Thanks. > thanks, > -- Shuah -- Regards, Vincenzo