From: Krzysztof Kozlowski <krzk@kernel.org>
To: "David Lechner" <dlechner@baylibre.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Ben Collins" <bcollins@watter.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Andrew Hepp" <andrew.hepp@ahepp.dev>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] dt-bindings: iio: mcp9600: Add compatible for microchip,mcp9601
Date: Mon, 18 Aug 2025 08:42:57 +0200 [thread overview]
Message-ID: <3f256b8e-dc7a-466d-be53-d6e324b44cb7@kernel.org> (raw)
In-Reply-To: <2025081717-fabulous-chameleon-5ad9bb@boujee-and-buff>
On 17/08/2025 23:10, Ben Collins wrote:
>>>>>
>>>>
>>>> I couldn't find anything that would easily describe this type of layout:
> ...
>>> We usually do this the other way around. The base binding lists
>>> all of the possibilities then an -if: constraint limits them
>>> if needed.
>>>
>>>
>>> So don't change what is there already and then add:
>>>
> ...
>> This might be a little more complicated. I want to add a boolean for
>> microchip,vsense so the SC/OC aren't even available without that flag
>> being true (default false).
>>
>> I could just assume that having the interrupts means this flag is true,
>> but that doesn't cover the case where the interrupts might not be used
>> or even wired up, but the SC/OC detection in the status register can be
>> used.
>>
>> I was going with this:
>>
>
> Nevermind, I figured this out. I'll send v4 soon.
You received from David correct code, good idea... yet you ignored it
and sent something incorrect - breaking ABI.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-18 6:43 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 16:46 [PATCH 0/5] iio: mcp9600: Features and improvements Ben Collins
2025-08-15 16:46 ` [PATCH 1/5] dt-bindings: iio: mcp9600: Add compatible for microchip,mcp9601 Ben Collins
2025-08-16 9:58 ` Jonathan Cameron
2025-08-16 18:55 ` David Lechner
2025-08-17 16:37 ` Ben Collins
2025-08-17 16:51 ` David Lechner
2025-08-17 17:34 ` Ben Collins
2025-08-17 17:59 ` David Lechner
2025-08-17 21:02 ` Ben Collins
2025-08-17 21:10 ` Ben Collins
2025-08-18 6:42 ` Krzysztof Kozlowski [this message]
2025-08-15 16:46 ` [PATCH 2/5] iio: mcp9600: White space cleanup for tab alignment Ben Collins
2025-08-16 9:59 ` Jonathan Cameron
2025-08-15 16:46 ` [PATCH 3/5] iio: mcp9600: Recognize chip id for mcp9601 Ben Collins
2025-08-16 8:46 ` kernel test robot
2025-08-16 10:02 ` Jonathan Cameron
2025-08-18 15:06 ` Nathan Chancellor
2025-08-18 15:11 ` Ben Collins
2025-08-18 15:18 ` Jonathan Cameron
2025-08-16 10:04 ` Jonathan Cameron
2025-08-15 16:46 ` [PATCH 4/5] iio: mcp9600: Add support for thermocouple-type Ben Collins
2025-08-16 10:11 ` Jonathan Cameron
2025-08-16 13:18 ` Ben Collins
2025-08-16 15:09 ` Jonathan Cameron
2025-08-16 18:24 ` David Lechner
2025-08-17 2:54 ` Ben Collins
2025-08-17 3:32 ` David Lechner
2025-08-15 16:46 ` [PATCH 5/5] iio: mcp9600: Add support for IIR filter Ben Collins
2025-08-16 10:15 ` Jonathan Cameron
2025-08-16 17:22 ` David Lechner
2025-08-16 10:07 ` [PATCH 0/5] iio: mcp9600: Features and improvements Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f256b8e-dc7a-466d-be53-d6e324b44cb7@kernel.org \
--to=krzk@kernel.org \
--cc=andrew.hepp@ahepp.dev \
--cc=andy@kernel.org \
--cc=bcollins@watter.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.