From: Mengmeng Zhao <mengmeng.zhao@linux.dev>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Dan Williams <djbw@kernel.org>,
Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
tytso@mit.edu, Andreas Dilger <adilger.kernel@dilger.ca>,
Baokun Li <libaokun@linux.alibaba.com>,
Ojaswin Mujoo <ojaswin@linux.ibm.com>,
"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
Zhang Yi <yi.zhang@huawei.com>,
"Darrick J. Wong" <djwong@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
asml.silence@gmail.com, Anuj Gupta <anuj1072538@gmail.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev,
linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-mm@kvack.org, Li Wang <liwang@kylinos.cn>
Subject: Re: [RFC 1/6] block: refuse a dma-buf bio that carries a crypto context
Date: Mon, 9 Nov 2026 10:51:46 +0800 [thread overview]
Message-ID: <3f45a5f9-9c87-420d-b6a5-6145c834c0d1@linux.dev> (raw)
In-Reply-To: <20261106104119.GA5668@lst.de>
On 11/6/26 18:41, Christoph Hellwig wrote:
> On Thu, Nov 05, 2026 at 02:58:42PM +0800, Mengmeng Zhao wrote:
>> + /* a dma-buf bio has no pages for integrity work or contents crypto */
>> if (unlikely(op_is_dmabuf(bio->bi_opf) &&
>> - bdev_has_integrity_csum(bio->bi_bdev))) {
>> + (bdev_has_integrity_csum(bio->bi_bdev) ||
>> + bio_has_crypt_ctx(bio)))) {
>
> This could really use a factored helper explaining all the refusals.
> And maybe we should use the chance to sit back and think what else
> would blow up and add it there as well.
>
Hi Christoph, thanks for the review. I will extract a helper in V2 soon.
There are several buffered io fallbacks, it's really necessary to discuss
how to avoid these. Glad to join it.
next prev parent reply other threads:[~2026-11-09 2:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 6:58 [RFC 0/6] ext4: Add dma-buf read/write support Mengmeng Zhao
2026-11-05 6:58 ` [RFC 1/6] block: refuse a dma-buf bio that carries a crypto context Mengmeng Zhao
2026-11-06 10:41 ` Christoph Hellwig
2026-11-09 2:51 ` Mengmeng Zhao [this message]
2026-11-05 6:58 ` [RFC 2/6] mm/filemap: refuse dmabuf iterators in the generic read/write copy paths Mengmeng Zhao
2026-11-06 10:42 ` Christoph Hellwig
2026-11-09 2:54 ` Mengmeng Zhao
2026-11-05 6:58 ` [RFC 3/6] dax: refuse dmabuf iterators in dax_iomap_rw() Mengmeng Zhao
2026-11-05 6:58 ` [RFC 4/6] iomap: refuse dmabuf iterators in iomap_file_buffered_write() Mengmeng Zhao
2026-11-05 6:58 ` [RFC 5/6] iomap: refuse dmabuf iterators on contents-encrypted inodes Mengmeng Zhao
2026-11-06 10:44 ` Christoph Hellwig
2026-11-09 2:56 ` Mengmeng Zhao
2026-11-05 6:58 ` [RFC 6/6] ext4: support dma-buf registered buffers for direct I/O Mengmeng Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f45a5f9-9c87-420d-b6a5-6145c834c0d1@linux.dev \
--to=mengmeng.zhao@linux.dev \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=anuj1072538@gmail.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=djbw@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=libaokun@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=liwang@kylinos.cn \
--cc=nvdimm@lists.linux.dev \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.