From: Michael Straube <straube.linux@gmail.com>
To: Phillip Potter <phil@philpotter.co.uk>, gregkh@linuxfoundation.org
Cc: fmdefrancesco@gmail.com, Larry.Finger@lwfinger.net,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] staging: r8188eu: cleanup c2h_handler code
Date: Sun, 29 Aug 2021 17:04:02 +0200 [thread overview]
Message-ID: <3f63d7e1-0eb4-21c0-49eb-262cdadf0e87@gmail.com> (raw)
In-Reply-To: <20210828212453.898-1-phil@philpotter.co.uk>
On 8/28/21 23:24, Phillip Potter wrote:
> This small patch set cleans up the c2h_handler code in the HAL layer
> of the driver. In r8188eu, this field of struct hal_ops, is not even
> used, so dependent code has always returned _FAIL. For this reason, we
> should remove this function pointer field, and the wrapper function
> which checks it. This is done in stages by this set, and helps get
> the driver closer to the pointer where the HAL layer is
> deleted/integrated as necessary and no longer a separate entity.
>
> Phillip Potter (3):
> staging: r8188eu: remove c2h_handler field from struct hal_ops
> staging: r8188eu: simplify c2h_evt_hdl function
> staging: r8188eu: remove rtw_hal_c2h_handler function
>
> drivers/staging/r8188eu/core/rtw_cmd.c | 23 +++-------------------
> drivers/staging/r8188eu/hal/hal_intf.c | 9 ---------
> drivers/staging/r8188eu/include/hal_intf.h | 4 ----
> 3 files changed, 3 insertions(+), 33 deletions(-)
>
Thanks for your patches Phillip. Looks good to me and I've built and
runtime tested this series with Inter-Tech DMG-02, so...
Acked-by: Michael Straube <straube.linux@gmail.com>
Thanks,
Michael
next prev parent reply other threads:[~2021-08-29 15:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-28 21:24 [PATCH 0/3] staging: r8188eu: cleanup c2h_handler code Phillip Potter
2021-08-28 21:24 ` [PATCH 1/3] staging: r8188eu: remove c2h_handler field from struct hal_ops Phillip Potter
2021-08-28 21:24 ` [PATCH 2/3] staging: r8188eu: simplify c2h_evt_hdl function Phillip Potter
2021-08-29 8:52 ` Fabio M. De Francesco
2021-08-29 10:49 ` Phillip Potter
2021-08-29 12:35 ` Fabio M. De Francesco
2021-08-29 11:54 ` Pavel Skripkin
2021-08-29 23:18 ` Phillip Potter
2021-08-30 8:06 ` Pavel Skripkin
2021-08-28 21:24 ` [PATCH 3/3] staging: r8188eu: remove rtw_hal_c2h_handler function Phillip Potter
2021-08-29 12:48 ` [PATCH 0/3] staging: r8188eu: cleanup c2h_handler code Fabio M. De Francesco
2021-08-29 22:59 ` Phillip Potter
2021-08-29 15:04 ` Michael Straube [this message]
2021-08-29 22:57 ` Phillip Potter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f63d7e1-0eb4-21c0-49eb-262cdadf0e87@gmail.com \
--to=straube.linux@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.