From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F347C10F11 for ; Sat, 13 Apr 2019 17:50:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 545E8208E3 for ; Sat, 13 Apr 2019 17:50:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="QDMrPQcN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727048AbfDMRt7 (ORCPT ); Sat, 13 Apr 2019 13:49:59 -0400 Received: from mail-pf1-f173.google.com ([209.85.210.173]:40799 "EHLO mail-pf1-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726620AbfDMRt7 (ORCPT ); Sat, 13 Apr 2019 13:49:59 -0400 Received: by mail-pf1-f173.google.com with SMTP id c207so6628822pfc.7 for ; Sat, 13 Apr 2019 10:49:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=qEguRuUlzoZ9JVGEgiZucMRroCoA0zXqrixq2tY1xoU=; b=QDMrPQcNv0LWTHJYwAG/mlnMePPx4iio7f2rpKsCYQnQvMGFWbDQ5wpND+JdbVl5dC q4E7J5rhvfEy+eU0dAAnv9VNq1SfTnzeOhvdGX3HyVNgL1b6akcoR5LEOiZtPgMrNHZn ikdp3QJoAXVP4MvMZmawQRWveyEv9KPaDaKMsxLjQCQvHEaqodGKBPfUc8WLrvf3bAYJ dzKOUgFuTeYwzT8SgSryPK6hfSsbCEIitGDlvBq30HZIifKNUnyMjK7HtrwiiGQDRKiD UDaV2fqeXU5RMws7w6SotAziiUCUYHzQAF7mKMJxMqIDlVFyXozfvizC1dI1T7WbR3Kz /McQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qEguRuUlzoZ9JVGEgiZucMRroCoA0zXqrixq2tY1xoU=; b=sGSgTXSbF93YREnbMqEnb5ZkycdCOaRdLOM4TqGlm7T9T0Hq7FRKcH9RCgASFtTU9B VI8QAC4VrtFxHku7/gF4C6gQKrMeGw2K+QJVEK+JpW3lJDMTKl1naS65kNnJ44/lLiwl LZZCva64hrGvKH4M3XMeY5f5JCDuVL5mkGJXOVdhf/A8OEDXhMOQ1FjHHsDuwJtR9Zeb IshJUuXIGGfXr0Y1F0wiO84IL02ivh0E1n+7fOYs2uDsSccPQO59xZ6YXtEyZy0q97gl 7IkNEsRuQNu/UTvqm4iaBU4sp4IUw9QR2snGixZzxF8xubLDniBgpjWM7fVTUcK/HPIh q1lg== X-Gm-Message-State: APjAAAUgurO7iRycP39sD20ikBzs/Er10VCHzBr3XzRb8rxXbh/zQn7h EnDivOmpiMPBKQVjZ0estbHi3uw86NVDGg== X-Google-Smtp-Source: APXvYqwlVwMmkdN3yGvyO8YZoLLjZ+UeSbaVAYC77jlQ4OLsgNQwPAwUYUH5RhZz0Zpwr1bg/twBEA== X-Received: by 2002:a65:64cf:: with SMTP id t15mr58873985pgv.322.1555177798017; Sat, 13 Apr 2019 10:49:58 -0700 (PDT) Received: from [192.168.1.121] (66.29.188.166.static.utbb.net. [66.29.188.166]) by smtp.gmail.com with ESMTPSA id f63sm83475746pfc.180.2019.04.13.10.49.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 13 Apr 2019 10:49:56 -0700 (PDT) Subject: Re: dead code in io_file_put() To: Al Viro Cc: linux-fsdevel@vger.kernel.org References: <20190413172750.GN2217@ZenIV.linux.org.uk> From: Jens Axboe Message-ID: <3f83273e-38ac-1016-2f37-60e33bc54304@kernel.dk> Date: Sat, 13 Apr 2019 11:49:54 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190413172750.GN2217@ZenIV.linux.org.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 4/13/19 11:27 AM, Al Viro wrote: > It's never called with NULL first argument anymore. > Is there any reason to keep that check (and the second argument, > never used when state != NULL) there? Good catch, looks like that part can go now. > Frankly, I wonder if there is any point in that > fget_many()/fput_many() stuff. Does the benefit from that > really show up in any profiles? It certainly made a difference for higher IOPS workloads. Of course we have the file registration now to negate that, but since we're using the state anyway for iocb allocation, it'd be a shame to drop the file ref cost amortization for the non-registered case. -- Jens Axboe