From: potturu venkata prasad <venkataprasad.potturu@amd.com>
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Cc: kernel@collabora.com, sound-open-firmware@alsa-project.org,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] ASoC: SOF: amd: Drop unused includes from Vangogh driver
Date: Mon, 10 Feb 2025 17:08:14 +0530 [thread overview]
Message-ID: <3f84884e-62e6-4b43-aa86-e1fe03507631@amd.com> (raw)
In-Reply-To: <20250207-sof-vangogh-fixes-v1-2-67824c1e4c9a@collabora.com>
On 2/7/25 17:16, Cristian Ciocaltea wrote:
> Remove all the includes for headers which are not (directly) used from
> the Vangogh SOF driver sources.
Okay.
Reviewed-by: Venkata Prasad Potturu <venkataprasad.potturu@amd.com>
>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> ---
> sound/soc/sof/amd/pci-vangogh.c | 2 --
> sound/soc/sof/amd/vangogh.c | 4 ----
> 2 files changed, 6 deletions(-)
>
> diff --git a/sound/soc/sof/amd/pci-vangogh.c b/sound/soc/sof/amd/pci-vangogh.c
> index 53f64d6bc91bae9e2ec506384a83b209a296860f..28f2d4050a6769335b5908c16946eff85aa7161d 100644
> --- a/sound/soc/sof/amd/pci-vangogh.c
> +++ b/sound/soc/sof/amd/pci-vangogh.c
> @@ -13,11 +13,9 @@
>
> #include <linux/module.h>
> #include <linux/pci.h>
> -#include <linux/platform_device.h>
> #include <sound/sof.h>
> #include <sound/soc-acpi.h>
>
> -#include "../ops.h"
> #include "../sof-pci-dev.h"
> #include "../../amd/mach-config.h"
> #include "acp.h"
> diff --git a/sound/soc/sof/amd/vangogh.c b/sound/soc/sof/amd/vangogh.c
> index d5f1dddd43e72dd62b3d031130193e6125edf9df..6ed5f9aaa414e696b0ae9b3bb83bd92a5dcd8d4b 100644
> --- a/sound/soc/sof/amd/vangogh.c
> +++ b/sound/soc/sof/amd/vangogh.c
> @@ -12,13 +12,9 @@
> */
>
> #include <linux/delay.h>
> -#include <linux/platform_device.h>
> #include <linux/module.h>
>
> -#include "../ops.h"
> -#include "../sof-audio.h"
> #include "acp.h"
> -#include "acp-dsp-offset.h"
>
> #define I2S_HS_INSTANCE 0
> #define I2S_BT_INSTANCE 1
>
next prev parent reply other threads:[~2025-02-10 11:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 11:46 [PATCH 0/4] Sound fix for Valve Steam Deck OLED on resume from suspend Cristian Ciocaltea
2025-02-07 11:46 ` [PATCH 1/4] ASoC: SOF: amd: Add post_fw_run_delay ACP quirk Cristian Ciocaltea
2025-02-07 12:35 ` Mukunda,Vijendar
2025-02-07 16:44 ` Cristian Ciocaltea
2025-02-07 11:46 ` [PATCH 2/4] ASoC: SOF: amd: Drop unused includes from Vangogh driver Cristian Ciocaltea
2025-02-10 11:38 ` potturu venkata prasad [this message]
2025-02-07 11:46 ` [PATCH 3/4] ASoC: SOF: amd: Handle IPC replies before FW_BOOT_COMPLETE Cristian Ciocaltea
2025-02-07 11:55 ` Mukunda,Vijendar
2025-02-07 12:16 ` Cristian Ciocaltea
2025-02-07 12:24 ` Mukunda,Vijendar
2025-02-07 17:00 ` Cristian Ciocaltea
2025-02-07 11:46 ` [PATCH 4/4] ASoC: SOF: amd: Add branch prediction hint in ACP IRQ handler Cristian Ciocaltea
2025-02-10 11:40 ` potturu venkata prasad
2025-02-10 16:41 ` [PATCH 0/4] Sound fix for Valve Steam Deck OLED on resume from suspend Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f84884e-62e6-4b43-aa86-e1fe03507631@amd.com \
--to=venkataprasad.potturu@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=broonie@kernel.org \
--cc=cristian.ciocaltea@collabora.com \
--cc=daniel.baluta@nxp.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=kernel@collabora.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.