From: Krzysztof Kozlowski <krzk@kernel.org>
To: Lefteris Koutrakis <lefteris.koutrakis@gmail.com>,
linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, maddy@linux.ibm.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
mpe@ellerman.id.au, npiggin@gmail.com, chleroy@kernel.org,
ritesh.list@gmail.com, sshegde@linux.ibm.com,
sashiko-bot@kernel.org
Subject: Re: [PATCH v6] powerpc/dts: Add Device Tree for WatchGuard Firebox T30 (v6)
Date: Thu, 29 Oct 2026 08:17:36 +0100 [thread overview]
Message-ID: <3f909a67-ffbd-49ff-a51c-e08cc15a5ec0@kernel.org> (raw)
In-Reply-To: <20261028194046.49784-1-lefteris.koutrakis@gmail.com>
On 28/10/2026 20:40, Lefteris Koutrakis wrote:
> This commit adds initial device tree support for the WatchGuard Firebox T30
Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94
Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.
> board and enables building firebox-t30.dtb under CONFIG_MPC85xx_RDB in
> arch/powerpc/boot/dts/fsl/Makefile. It also documents the watchguard vendor
> prefix in vendor-prefixes.yaml.
>
> Signed-off-by: Lefteris Koutrakis <lefteris.koutrakis@gmail.com>
> ---
> .../devicetree/bindings/vendor-prefixes.yaml | 2 +
> arch/powerpc/boot/dts/fsl/Makefile | 1 +
> arch/powerpc/boot/dts/fsl/firebox-t30.dts | 386 ++++++++++++++++++
> .../arch/powerpc/boot/dts/firebox-t30.dts | 386 ++++++++++++++++++
> 4 files changed, 775 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/vendor-prefixes.yaml
> create mode 100644 arch/powerpc/boot/dts/fsl/Makefile
> create mode 100644 arch/powerpc/boot/dts/fsl/firebox-t30.dts
> create mode 100644 target/linux/mpc85xx/files/arch/powerpc/boot/dts/firebox-t30.dts
>
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> new file mode 100644
> index 0000000..c78a53f
> --- /dev/null
Not existing? You are sending some random changes to us. Please slow
down, read the docs how to use Git and how to generate patches.
Documentation/process (including submitting patches) will be helpful.
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -0,0 +1,2 @@
> + "watchguard,":
> + description: WatchGuard Technologies, Inc.
> diff --git a/arch/powerpc/boot/dts/fsl/Makefile b/arch/powerpc/boot/dts/fsl/Makefile
> new file mode 100644
> index 0000000..60caf36
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-10-29 7:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 19:40 [PATCH v6] powerpc/dts: Add Device Tree for WatchGuard Firebox T30 (v6) Lefteris Koutrakis
2026-10-29 7:17 ` Krzysztof Kozlowski [this message]
2026-10-29 9:41 ` Lefteris Koutrakis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f909a67-ffbd-49ff-a51c-e08cc15a5ec0@kernel.org \
--to=krzk@kernel.org \
--cc=chleroy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lefteris.koutrakis@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=ritesh.list@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=sshegde@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.