From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=intel.com (client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=ed.tanous@intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=intel.com Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 466t896kZ6zDqWv for ; Tue, 13 Aug 2019 09:57:55 +1000 (AEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Aug 2019 16:57:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,379,1559545200"; d="scan'208";a="183715681" Received: from hades.jf.intel.com (HELO [10.54.51.78]) ([10.54.51.78]) by FMSMGA003.fm.intel.com with ESMTP; 12 Aug 2019 16:57:52 -0700 Subject: Re: template replacement To: openbmc@lists.ozlabs.org References: From: Ed Tanous Message-ID: <3f980968-f67f-1529-e681-e351c597a2ff@intel.com> Date: Mon, 12 Aug 2019 16:57:52 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Aug 2019 23:58:02 -0000 On 8/12/19 9:10 AM, Patrick Venture wrote: > I've run into an issue and before I submitted a patch to solve my > specific problem, I wanted to get a sense of what was intended: > > I have a field "name" that I want to set dynamically to "$bus_v2345_0_local" > It finds the $bus match but then fails on the split. > If I add a " " it then fails as well. > Probably just a bug. A quick scan of $bus in the configurations shows that we've only ever used it in cases where it was the complete string (ie "$bus") and even then, only used to populate numeric interfaces with the bus number to be used programmatically by downstream sensors. Some of the intent was to largely remove the bus number from the device naming convention, as outside the system the bus topology is largely irrelevant. With that said, I could see how that might be desired for some setups. > It seems to be that if a template is at the end of the field, it works > fine, otherwise it assumes there must be some operation to perform. > > Did you already have a fix in mind? James is out the next few days, so his answer might differ from mine when he gets back, but I don't think we knew about this issue previously.