From: Matthieu Baerts <matttbe@kernel.org>
To: Kalpan Jani <kalpan.jani@mpiricsoftware.com>
Cc: mptcp <mptcp@lists.linux.dev>, martineau <martineau@kernel.org>,
pabeni <pabeni@redhat.com>,
"shardul.b" <shardul.b@mpiricsoftware.com>,
janak <janak@mpiric.us>, kalpanjani009 <kalpanjani009@gmail.com>,
shardulsb08 <shardulsb08@gmail.com>
Subject: Re: [PATCH net v2] mptcp: pm: drop pending ADD_ADDR when removing id 0 endpoint
Date: Tue, 7 Jul 2026 16:14:57 +0200 [thread overview]
Message-ID: <3fa5bb51-f140-4cbb-b748-d264232c3eae@kernel.org> (raw)
In-Reply-To: <19f3cca8500.ef8eb681856418.2642565239132356618@mpiricsoftware.com>
On 07/07/2026 15:35, Kalpan Jani wrote:
> Hi Matt,
> Thank you for pointing me to add_addr_retry_errors.pkt — that makes the idiom clear. Inject a data packet after the del+re-add sequence and expect a plain DSS ACK back with no add_address option piggybacked. On an unfixed kernel the stale entry causes a spurious ADD_ADDR(id=0) retransmit to appear on that ACK, which packetdrill catches as an unexpected option.
Great!
> I will write the packetdrill test using that pattern and send v6 with:
>
> Patch 1: kernel fix (also correcting the addr argument — the &anno_addr copy in v5 is fragile for with-port endpoints)
If that's the same version as the v5, no need to resend it.
> Patch 2: packetdrill regression test in gtests/net/mptcp/regressions/
Can you open a PR instead, please?
https://github.com/multipath-tcp/packetdrill/
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2026-07-07 14:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 6:43 [PATCH net v2] mptcp: pm: drop pending ADD_ADDR when removing id 0 endpoint Kalpan Jani
2026-05-29 6:55 ` Matthieu Baerts
2026-05-29 7:18 ` Kalpan Jani
2026-05-31 6:39 ` Matthieu Baerts
2026-06-01 11:59 ` Kalpan Jani
2026-07-06 16:46 ` Matthieu Baerts
2026-07-07 6:15 ` Kalpan Jani
2026-07-07 11:27 ` Matthieu Baerts
2026-07-07 13:35 ` Kalpan Jani
2026-07-07 14:14 ` Matthieu Baerts [this message]
2026-07-08 5:31 ` Kalpan Jani
2026-05-29 7:58 ` MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fa5bb51-f140-4cbb-b748-d264232c3eae@kernel.org \
--to=matttbe@kernel.org \
--cc=janak@mpiric.us \
--cc=kalpan.jani@mpiricsoftware.com \
--cc=kalpanjani009@gmail.com \
--cc=martineau@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=shardul.b@mpiricsoftware.com \
--cc=shardulsb08@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.