From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 119D5C27C79 for ; Mon, 17 Jun 2024 19:31:33 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B7A25836; Mon, 17 Jun 2024 21:31:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B7A25836 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1718652691; bh=N8H94RCXX5YWmY4bchJl16LRzX71/Gf5z7MQzkptBOQ=; h=Date:To:Cc:References:Subject:From:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=WZ6vEJNOitlXLMMQDIVYG3wf2Su2QLmZIdVWnlg7YA2Nh8H+n6ZVp10LAncttim3E MKLibHkI0sletM9dF0jJf+X2aVRkWx91F2VfywcHl27+6CIgZFeTMdHCNw/rFQqxQJ Cn+RNd35rTn0DNgZ8K31OyODyXL6es7FLiPu7Gk4= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6644BF80589; Mon, 17 Jun 2024 21:30:50 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id D54BCF80589; Mon, 17 Jun 2024 21:30:49 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 78ACDF8023A; Mon, 17 Jun 2024 21:30:42 +0200 (CEST) Received: from mout.web.de (mout.web.de [212.227.15.14]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1FFD5F80154 for ; Mon, 17 Jun 2024 21:30:37 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1FFD5F80154 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=web.de header.i=markus.elfring@web.de header.a=rsa-sha256 header.s=s29768273 header.b=lxK6l8qH DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1718652624; x=1719257424; i=markus.elfring@web.de; bh=3SqP/MMqLPtLI6/aIyy4H8OAKdv545+Ewr3toVxYkx8=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=lxK6l8qHCP4V1dzgSMS0KoLyJcIOqUqxTPlHRybAA5du8RWKPdPKrbDwqryvbaA+ ku6Q70PsujUK2P/VJPb19+vva241tw40t5Gozdp7kZlVN3IajMWiE63z5mdFvlhpd 4JAL61sw/vzLZbTvIc+05/scPEIr/91nQJ/PmywfVGfaCQpwgYbYIRSlCu/CMt9d8 l6bfRFqb+kzLU/O/z5xYn768epuQhVhFHuPwYAZaA37bmhTS+nY+ueL8Epqh4B/QV 41JZHoaSLCc3YwhpYxg1uHLIpA90hAyvPjTrwlpZZVRgvH/icgPfkUPugCDnFIQFq YORSTWRQUR4/w07htw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.83.95]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1N3Gkg-1sSbPm0CNW-00tTYm; Mon, 17 Jun 2024 21:30:24 +0200 Message-ID: <3fb7f6db-6822-413e-9aa3-953a5e3cd566@web.de> Date: Mon, 17 Jun 2024 21:30:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Piotr Wojtaszczyk , alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org Cc: LKML , Arnd Bergmann , Chancel Liu , Conor Dooley , Jaroslav Kysela , Jonathan Downing , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Michael Ellerman , Rob Herring , Russell King , Takashi Iwai , Vladimir Zapolskiy References: <20240614163500.386747-5-piotr.wojtaszczyk@timesys.com> Subject: Re: [PATCH v3 4/4] ASoC: fsl: Add i2s and pcm drivers for LPC32xx CPUs Content-Language: en-GB From: Markus Elfring In-Reply-To: <20240614163500.386747-5-piotr.wojtaszczyk@timesys.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:5WMvwVJ2f6aoUtr+Iz89hHXdsaVQ1zgvfdIEvfLMhBHDYIBbpe8 kWz8j5Flzg276xCuQhuOfkGfjJ1JGGY3ujMyZc1pPd3x6QKmrtdsQqX0puZR60X7t0lHxCa yn6PJPgg+aEg447/N0AipP2n+YrYMaefQ7ZzL7N5WylGgwQ1/vOzILgz7mqlOpdJg0hrWyK EoJrGwmfCJ2IviYQn3jgw== UI-OutboundReport: notjunk:1;M01:P0:pVQb5So6FAw=;pG6zPJf8wb9vzA5LF4jNtqDv5o9 /wfXRJYnT2hL1wOkqCS6+05DfJyBbhU/xgs8pdwSkRtjLcqlmPcGEtlDB1Z0f9afby7Q7cl2r fjDwU4ET68ARBeeByqSmPSEdoR0v0HLJvckBTcabIUuIIQ4UO3LEvZt+Fp7IsW4OaYeciDyqI +A2MX/lbwSNdSR94Qbm8V39m0dirWA1dpq4S/XjtTXhpSH/Zx6JIGMmOlYqyRs8QCr5b8FHyu Ft5j1tESNqOW3hsjtghA9HBQlLk0Hvky3Jpwe4LmbkMwrnH/AT9KZSk4B15cEtdcPciaY7jo1 bllphSeyrZggD/vn81zh9Vjk5bXg5TyA/Z6gRkuqYbkOvvIMOtHf+0JZ2HhrIqxwdT44p5QaW 91T8VQNQpl38vjRziItj2ATMM19SFvZYkiLYib/QjEcHXVMmInPRGpz+7YxZaVHX1MBOXHegb ocJWpJczl2/h1Z8tjlLRJcrE9J7a6uGm56DywHHcdErGqLZVgfiwvusvyWCaoKjVvjcCDKWN8 g6Ks6/qjqbA5Q9OT+Yr0mh1+stw1jiWiTFoHwpgfD54jcvW7rHhK4OzDV5hFOyzXxFd5xKa8Q z+urECA15gba149mNdOnz9VeFUTExRUzylb/SzuhzVhy4rk0Wil531qrfrficv97vSTiSYSO5 2xPSxWHhUshXUiksmYiRVbFVXxjy1PFOcAG+O6MyXKYdH1tQaa2zymjTABfb+Mo2WgRKxxlDj 2cX4jB9fM1IhJ1Ej4T5s5jvCHT9ctWrw5NbFrQ51/kAmJg0pWeO3iyMWAHmBxSDod5pryVvfS Sb7KS14QZHcngaaeSBfJ6YZFYLOay+D8GPM9Px+5EvgMU= Message-ID-Hash: 4T4TMECOPVONH7EJFKCSB4Q2URSFTDUV X-Message-ID-Hash: 4T4TMECOPVONH7EJFKCSB4Q2URSFTDUV X-MailFrom: Markus.Elfring@web.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: I suggest to specify email addresses for message recipients not only in the header field =E2=80=9CCc=E2=80=9D. =E2=80=A6 > +++ b/sound/soc/fsl/lpc3xxx-i2s.c > @@ -0,0 +1,393 @@ =E2=80=A6 > +static int lpc3xxx_i2s_startup(struct snd_pcm_substream *substream, str= uct snd_soc_dai *cpu_dai) > +{ =E2=80=A6 > + int ret =3D 0; > + > + mutex_lock(&i2s_info_p->lock); =E2=80=A6 > +lpc32xx_unlock: > + mutex_unlock(&i2s_info_p->lock); > + return ret; > +} =E2=80=A6 Would you become interested to apply a statement like =E2=80=9Cguard(mutex= )(&i2s_info_p->lock);=E2=80=9D? https://elixir.bootlin.com/linux/v6.10-rc4/source/include/linux/mutex.h#L1= 96 Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23340C27C79 for ; Mon, 17 Jun 2024 19:37:59 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=web.de header.i=markus.elfring@web.de header.a=rsa-sha256 header.s=s29768273 header.b=qFy9OqZ+; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4W30Xj46vbz3gD8 for ; Tue, 18 Jun 2024 05:37:57 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=web.de header.i=markus.elfring@web.de header.a=rsa-sha256 header.s=s29768273 header.b=qFy9OqZ+; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=web.de (client-ip=212.227.15.14; helo=mout.web.de; envelope-from=markus.elfring@web.de; receiver=lists.ozlabs.org) X-Greylist: delayed 349 seconds by postgrey-1.37 at boromir; Tue, 18 Jun 2024 05:37:12 AEST Received: from mout.web.de (mout.web.de [212.227.15.14]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4W30Wr4Vqvz3g7P for ; Tue, 18 Jun 2024 05:37:11 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1718653019; x=1719257819; i=markus.elfring@web.de; bh=3SqP/MMqLPtLI6/aIyy4H8OAKdv545+Ewr3toVxYkx8=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=qFy9OqZ+61yp2Rr2rTlaNNqY3iWEj82Su6VHQlqnYJfawxb2t3p84wmz+i+lfa2a 9VnvM09uvYl9MKAqtmm06clNbE0mXeOptfJtNazwkRbYbLdx8iws9V0/LhlvliNI5 Zunk4uoQn8GX45NhaXBaSkvTj4fBYA+bRALZinkLVvb/ybcKgFdqdqHOxyzw7BBGJ 5AFU2r3iE51ZRTjdJpMPmEvyEybEsdQjASm3ns0kVH3L+30XktQui8AYQYDZHErpi RnfL8ZUP7qX2GyMVAhRfcsfj2iVcLLqdzbOaR1xWUtilfclR1Nn3Ss/Gt9CJKi4RU g6rZ9obCMXGeqxd17w== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.83.95]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1N3Gkg-1sSbPm0CNW-00tTYm; Mon, 17 Jun 2024 21:30:24 +0200 Message-ID: <3fb7f6db-6822-413e-9aa3-953a5e3cd566@web.de> Date: Mon, 17 Jun 2024 21:30:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Piotr Wojtaszczyk , alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org References: <20240614163500.386747-5-piotr.wojtaszczyk@timesys.com> Subject: Re: [PATCH v3 4/4] ASoC: fsl: Add i2s and pcm drivers for LPC32xx CPUs Content-Language: en-GB From: Markus Elfring In-Reply-To: <20240614163500.386747-5-piotr.wojtaszczyk@timesys.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:5WMvwVJ2f6aoUtr+Iz89hHXdsaVQ1zgvfdIEvfLMhBHDYIBbpe8 kWz8j5Flzg276xCuQhuOfkGfjJ1JGGY3ujMyZc1pPd3x6QKmrtdsQqX0puZR60X7t0lHxCa yn6PJPgg+aEg447/N0AipP2n+YrYMaefQ7ZzL7N5WylGgwQ1/vOzILgz7mqlOpdJg0hrWyK EoJrGwmfCJ2IviYQn3jgw== UI-OutboundReport: notjunk:1;M01:P0:289MEY1k7K8=;iOOAW6vyjkidRXUo1txuUPephTd Lu1fLFFQ6OiCdw7XqOVx+w2a20k6HujWOHtSQ8ZBlGo/WuwY98D89FpuXLguWAWGVOl0qUIhe jc0zM6Y/szMGY+/WlykVXOVhOrLwVuova8HBzv7uV1hrETD7wvDm2z5WgXmqJQxbD0oy6g1n4 96zeP7oB9vXE5vRN8plGOvQoTt7SSUequ7lc+YSbYRC563Eg2wHsMUVtXddeBQtIwH+K5e2fL FK/5gEqssQlX1EcTxtUDtMj59u8f3/tfig1/7zuXaemfMmKMToZZ4sPidUNjPJFfNENxhD+FZ sFEnxnYTxIhbJ3GTw70uWGJpy1FCI80Xz/49TVeQStMHl6rku0TMl0JSmMUoTqibbRB4kJc0e 7VB3CB8pMhET7dINxpOTEavR1IjfgXauixR6RgI/klq8k5HxjD7R4s2CoTkyfo5j4gczHHyea uLQhNNkNl9dcJEMLqgeT9TbU1OAZHzgQ3p1BlYa8qjorYW5kfp+ffxczoT+vi/IUMxXJyNiIG RYZ1HTj6oy3q+dTkHv7WvPJxCk1gQDxvloh9NK+9bruoEk/uzlpDpAyF642GPqGqw+z2LdBcV UO6maK85XEM0es5DTY3E9O9oj0JX0iFlTLMn4+phGIuzTzEkmsAxwrixRsE537NT7nn5JkMLV 1RdVvS8UeTGPMjpyGaEKa+2F5vxG19XllG9vBQk4KBooBPqzV+MoCky4+nIq1nA2scdl30sD9 BXSDEwLRSTDA7GIgwW57s28eF/GWnmh5al7DlTHI/7o9P3KtlTaywCCpXvs+w/LHJPw7I8ik5 3znkE+XmhoI8DG2/24UILJqI3JkvyvehkDbfd4qGA6mug= X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Conor Dooley , Arnd Bergmann , Liam Girdwood , Takashi Iwai , LKML , Jonathan Downing , Jaroslav Kysela , Krzysztof Kozlowski , Mark Brown , Chancel Liu , Russell King , Vladimir Zapolskiy Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" I suggest to specify email addresses for message recipients not only in the header field =E2=80=9CCc=E2=80=9D. =E2=80=A6 > +++ b/sound/soc/fsl/lpc3xxx-i2s.c > @@ -0,0 +1,393 @@ =E2=80=A6 > +static int lpc3xxx_i2s_startup(struct snd_pcm_substream *substream, str= uct snd_soc_dai *cpu_dai) > +{ =E2=80=A6 > + int ret =3D 0; > + > + mutex_lock(&i2s_info_p->lock); =E2=80=A6 > +lpc32xx_unlock: > + mutex_unlock(&i2s_info_p->lock); > + return ret; > +} =E2=80=A6 Would you become interested to apply a statement like =E2=80=9Cguard(mutex= )(&i2s_info_p->lock);=E2=80=9D? https://elixir.bootlin.com/linux/v6.10-rc4/source/include/linux/mutex.h#L1= 96 Regards, Markus