All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: driver-core@lists.linux.dev, linux-kernel@vger.kernel.org,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Danilo Krummrich <dakr@kernel.org>, NeilBrown <neil@brown.name>
Subject: Re: [PATCH] sysfs: clamp show() return value in sysfs_kf_read()
Date: Wed, 20 May 2026 08:19:34 -1000	[thread overview]
Message-ID: <3fb84b4c71fce994cfe1e06a5fe3970f@kernel.org> (raw)
In-Reply-To: <2026052000-drove-unicycle-d61b@gregkh>

Hello,

Two nits:

- Buffer is atomic_write_len ?: PAGE_SIZE, so probably better to clamp
  to that than hardcode PAGE_SIZE.

- pr_warn() instead of bare printk()?

Thanks.

-- 
tejun

  parent reply	other threads:[~2026-05-20 18:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-20 13:07 [PATCH] sysfs: clamp show() return value in sysfs_kf_read() Greg Kroah-Hartman
2026-05-20 13:36 ` Rafael J. Wysocki
2026-05-20 14:43 ` Danilo Krummrich
2026-05-20 18:19 ` Tejun Heo [this message]
2026-05-21  6:18   ` Greg Kroah-Hartman
2026-05-21 10:04     ` David Laight
2026-05-21 16:18     ` Tejun Heo
2026-05-21 21:42       ` David Laight
2026-05-20 22:11 ` David Laight
2026-05-21  6:19   ` Greg Kroah-Hartman
2026-05-21  9:17     ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3fb84b4c71fce994cfe1e06a5fe3970f@kernel.org \
    --to=tj@kernel.org \
    --cc=dakr@kernel.org \
    --cc=driver-core@lists.linux.dev \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neil@brown.name \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.