From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH] block: Add block level changes for inline encryption To: Ladvine D Almeida , "ming.lei@redhat.com" Cc: "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Manjunath M Bettegowda , Prabu Thangamuthu , Tejas Joglekar , Joao Pinto References: <77544032-b6ff-bc5e-9fec-666e66b2cc70@kernel.dk> From: Jens Axboe Message-ID: <3fc7786c-af85-d047-047f-44d4eded6124@kernel.dk> Date: Thu, 31 May 2018 09:46:07 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 List-ID: On 5/31/18 1:47 AM, Ladvine D Almeida wrote: > On Monday 28 May 2018 04:54 PM, Jens Axboe wrote: >> On 5/28/18 7:43 AM, Ladvine D Almeida wrote: >>> This patch introduces new variable under bio structure to >>> facilitate inline encryption. This variable is used to >>> associate I/O requests to crypto information. >> Hard no on this, for two reasons: >> >> 1) Any additions to struct bio are scrutinized heavily and >> need strong justification. > > Thanks for sharing your feedback on the patch. > I am providing reference to an earlier article related to inline encryption support below: > https://lwn.net/Articles/717754/ Took a quick look, and this looks like a classic case of something that should just be a cloned bio. If you clone, you own the bi_private field, which is what you need. -- Jens Axboe