From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: [PATCH v3] drm/bridge: Build the panel wrapper in drm_kms_helper Date: Tue, 6 Jun 2017 16:31:50 +0200 Message-ID: <3fd262cf-1db6-4335-320c-af92f9014502@linux.intel.com> References: <20170602202514.11900-1-eric@anholt.net> <2ab4e84f-9834-1dce-d16a-14f9cc4083e9@codeaurora.org> <2cbcbf54-debf-10a1-390d-128171d81f91@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6C68C6E104 for ; Tue, 6 Jun 2017 14:31:53 +0000 (UTC) In-Reply-To: <2cbcbf54-debf-10a1-390d-128171d81f91@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Archit Taneja , Eric Anholt , Andrzej Hajda , Laurent Pinchart , Thierry Reding Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org VGhpcyBmaXhlcyB0aGUgZm9sbG93aW5nIGRlcG1vZCBlcnJvciB3aGVuIGJ1aWxkaW5nIGRybSBh cyBhIG1vZHVsZToKZGVwbW9kOiBFUlJPUjogRm91bmQgNiBtb2R1bGVzIGluIGRlcGVuZGVuY3kg Y3ljbGVzIQpkZXBtb2Q6IEVSUk9SOiBDeWNsZSBkZXRlY3RlZDogZHJtIC0+IGRybV9rbXNfaGVs cGVyIC0+IGRybQoKRml4ZXM6IDEzZGZjMDU0MGE1NyAoImRybS9icmlkZ2U6IFJlZmFjdG9yIG91 dCB0aGUgcGFuZWwgd3JhcHBlciBmcm9tIHRoZSBsdmRzLWVuY29kZXIgYnJpZGdlLiIpClNpZ25l ZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRl bC5jb20+Ci0tLQpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL01ha2VmaWxlIGIvZHJpdmVy cy9ncHUvZHJtL01ha2VmaWxlCmluZGV4IGRjNjkxNzUyNTViMS4uMzk5OWRmZmNkOWVmIDEwMDY0 NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vTWFrZWZpbGUKKysrIGIvZHJpdmVycy9ncHUvZHJtL01h a2VmaWxlCkBAIC0yNCw3ICsyNCw2IEBAIGRybS0kKENPTkZJR19DT01QQVQpICs9IGRybV9pb2Mz Mi5vCiBkcm0tJChDT05GSUdfRFJNX0dFTV9DTUFfSEVMUEVSKSArPSBkcm1fZ2VtX2NtYV9oZWxw ZXIubwogZHJtLSQoQ09ORklHX1BDSSkgKz0gYXRpX3BjaWdhcnQubwogZHJtLSQoQ09ORklHX0RS TV9QQU5FTCkgKz0gZHJtX3BhbmVsLm8KLWRybS0kKENPTkZJR19EUk1fUEFORUxfQlJJREdFKSAr PSBicmlkZ2UvcGFuZWwubwogZHJtLSQoQ09ORklHX09GKSArPSBkcm1fb2YubwogZHJtLSQoQ09O RklHX0FHUCkgKz0gZHJtX2FncHN1cHBvcnQubwogZHJtLSQoQ09ORklHX0RFQlVHX0ZTKSArPSBk cm1fZGVidWdmcy5vIGRybV9kZWJ1Z2ZzX2NyYy5vCkBAIC0zNSw2ICszNCw3IEBAIGRybV9rbXNf aGVscGVyLXkgOj0gZHJtX2NydGNfaGVscGVyLm8gZHJtX2RwX2hlbHBlci5vIGRybV9wcm9iZV9o ZWxwZXIubyBcCiAJCWRybV9zaW1wbGVfa21zX2hlbHBlci5vIGRybV9tb2Rlc2V0X2hlbHBlci5v IFwKIAkJZHJtX3NjZGNfaGVscGVyLm8KIAorZHJtX2ttc19oZWxwZXItJChDT05GSUdfRFJNX1BB TkVMX0JSSURHRSkgKz0gYnJpZGdlL3BhbmVsLm8KIGRybV9rbXNfaGVscGVyLSQoQ09ORklHX0RS TV9MT0FEX0VESURfRklSTVdBUkUpICs9IGRybV9lZGlkX2xvYWQubwogZHJtX2ttc19oZWxwZXIt JChDT05GSUdfRFJNX0ZCREVWX0VNVUxBVElPTikgKz0gZHJtX2ZiX2hlbHBlci5vCiBkcm1fa21z X2hlbHBlci0kKENPTkZJR19EUk1fS01TX0NNQV9IRUxQRVIpICs9IGRybV9mYl9jbWFfaGVscGVy Lm8KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751585AbdFFOcA (ORCPT ); Tue, 6 Jun 2017 10:32:00 -0400 Received: from mga02.intel.com ([134.134.136.20]:8371 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751563AbdFFOb6 (ORCPT ); Tue, 6 Jun 2017 10:31:58 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,306,1493708400"; d="scan'208";a="95211316" Subject: [PATCH v3] drm/bridge: Build the panel wrapper in drm_kms_helper To: Archit Taneja , Eric Anholt , Andrzej Hajda , Laurent Pinchart , Thierry Reding Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20170602202514.11900-1-eric@anholt.net> <2ab4e84f-9834-1dce-d16a-14f9cc4083e9@codeaurora.org> <2cbcbf54-debf-10a1-390d-128171d81f91@linux.intel.com> From: Maarten Lankhorst Message-ID: <3fd262cf-1db6-4335-320c-af92f9014502@linux.intel.com> Date: Tue, 6 Jun 2017 16:31:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <2cbcbf54-debf-10a1-390d-128171d81f91@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This fixes the following depmod error when building drm as a module: depmod: ERROR: Found 6 modules in dependency cycles! depmod: ERROR: Cycle detected: drm -> drm_kms_helper -> drm Fixes: 13dfc0540a57 ("drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.") Signed-off-by: Maarten Lankhorst --- diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index dc69175255b1..3999dffcd9ef 100644 --- a/drivers/gpu/drm/Makefile +++ b/drivers/gpu/drm/Makefile @@ -24,7 +24,6 @@ drm-$(CONFIG_COMPAT) += drm_ioc32.o drm-$(CONFIG_DRM_GEM_CMA_HELPER) += drm_gem_cma_helper.o drm-$(CONFIG_PCI) += ati_pcigart.o drm-$(CONFIG_DRM_PANEL) += drm_panel.o -drm-$(CONFIG_DRM_PANEL_BRIDGE) += bridge/panel.o drm-$(CONFIG_OF) += drm_of.o drm-$(CONFIG_AGP) += drm_agpsupport.o drm-$(CONFIG_DEBUG_FS) += drm_debugfs.o drm_debugfs_crc.o @@ -35,6 +34,7 @@ drm_kms_helper-y := drm_crtc_helper.o drm_dp_helper.o drm_probe_helper.o \ drm_simple_kms_helper.o drm_modeset_helper.o \ drm_scdc_helper.o +drm_kms_helper-$(CONFIG_DRM_PANEL_BRIDGE) += bridge/panel.o drm_kms_helper-$(CONFIG_DRM_LOAD_EDID_FIRMWARE) += drm_edid_load.o drm_kms_helper-$(CONFIG_DRM_FBDEV_EMULATION) += drm_fb_helper.o drm_kms_helper-$(CONFIG_DRM_KMS_CMA_HELPER) += drm_fb_cma_helper.o