From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA2B4C433DB for ; Wed, 23 Dec 2020 16:42:11 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 80A8520897 for ; Wed, 23 Dec 2020 16:42:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 80A8520897 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.58520.102997 (Exim 4.92) (envelope-from ) id 1ks7D3-00022E-5k; Wed, 23 Dec 2020 16:41:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 58520.102997; Wed, 23 Dec 2020 16:41:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ks7D3-000227-2i; Wed, 23 Dec 2020 16:41:57 +0000 Received: by outflank-mailman (input) for mailman id 58520; Wed, 23 Dec 2020 16:41:55 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ks7D1-00021o-Il for xen-devel@lists.xenproject.org; Wed, 23 Dec 2020 16:41:55 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3b8c4c7e-fc3c-4c9b-80eb-edee12388e81; Wed, 23 Dec 2020 16:41:54 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7E27EACF1; Wed, 23 Dec 2020 16:41:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b8c4c7e-fc3c-4c9b-80eb-edee12388e81 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1608741713; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O9OOtA8Qc/tES3oyETCPx+qqFk54z+xzGKtXLHHlof8=; b=vEgprFgdIii6UYfy+7T9yE8j6sxQsFoQqB5jcBFosL4nohggNofzN5fH6MTJwayS0B02LM syvlsieyOXVGpd2NFvstKwCtCG1IPZdWdyt/OOswdsaJd01+19vzW364v5XLr8RS2LtRN+ PUfx76doQ0VciZ9+sKu9eca1mH9Ghrc= Subject: Re: [PATCH 4/4] tools/misc: Test for fault injection To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Tamas K Lengyel , Xen-devel References: <20201223163442.8840-1-andrew.cooper3@citrix.com> <20201223163442.8840-5-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: <3fe99df6-ea2a-d877-8cb9-a4e7e84589d0@suse.com> Date: Wed, 23 Dec 2020 17:41:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20201223163442.8840-5-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 23.12.2020 17:34, Andrew Cooper wrote: > --- /dev/null > +++ b/tools/misc/xen-fault-ttl.c > @@ -0,0 +1,56 @@ > +#include > +#include > +#include > +#include > + > +#include > + > +int main(int argc, char **argv) > +{ > + int rc; > + xc_interface *xch = xc_interface_open(NULL, NULL, 0); > + > + if ( !xch ) > + err(1, "xc_interface_open"); > + > + struct xen_domctl_createdomain create = { > + .fault_ttl = 1, > + .flags = (XEN_DOMCTL_CDF_hvm | > + XEN_DOMCTL_CDF_hap), > + .max_vcpus = 1, > + .max_evtchn_port = -1, > + .max_grant_frames = 64, > + .max_maptrack_frames = 1024, > + .arch = { > + .emulation_flags = XEN_X86_EMU_LAPIC, > + }, > + }; > + uint32_t domid = 0; > + > + for ( rc = 1; rc && errno == ENOMEM; create.fault_ttl++ ) > + rc = xc_domain_create(xch, &domid, &create); The very first time you get here, how does errno end up being set to ENOMEM? To me do { create.fault_ttl++; rc = xc_domain_create(xch, &domid, &create); } while ( rc && errno == ENOMEM ); would seem more natural (and also avoid the somewhat odd "rc = 1"). Jan