From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 16/38] drm/i915: Introduce a context barrier callback Date: Mon, 4 Mar 2019 08:55:35 +0000 Message-ID: <3ff2ec03-6a2b-261a-1a12-111f4b8d2538@linux.intel.com> References: <20190301140404.26690-1-chris@chris-wilson.co.uk> <20190301140404.26690-16-chris@chris-wilson.co.uk> <155146700922.14887.8794404356785637929@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5C0C489339 for ; Mon, 4 Mar 2019 08:55:37 +0000 (UTC) In-Reply-To: <155146700922.14887.8794404356785637929@skylake-alporthouse-com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDAxLzAzLzIwMTkgMTk6MDMsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE5LTAzLTAxIDE2OjEyOjMzKQo+Pgo+PiBPbiAwMS8wMy8yMDE5IDE0OjAz LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiArICAgICBjb3VudGVyID0gMDsKPj4+ICsgICAgIGVy ciA9IGNvbnRleHRfYmFycmllcl90YXNrKGN0eCwgMCwgbW9ja19iYXJyaWVyX3Rhc2ssICZjb3Vu dGVyKTsKPj4+ICsgICAgIGlmIChlcnIpIHsKPj4+ICsgICAgICAgICAgICAgcHJfZXJyKCJGYWls ZWQgYXQgbGluZSAlZCwgZXJyPSVkXG4iLCBfX0xJTkVfXywgZXJyKTsKPj4+ICsgICAgICAgICAg ICAgZ290byBvdXQ7Cj4+PiArICAgICB9Cj4+PiArICAgICBpZiAoY291bnRlciA9PSAwKSB7Cj4+ PiArICAgICAgICAgICAgIHByX2VycigiRGlkIG5vdCByZXRpcmUgaW1tZWRpYXRlbHkgd2l0aCAw IGVuZ2luZXNcbiIpOwo+Pj4gKyAgICAgICAgICAgICBlcnIgPSAtRUlOVkFMOwo+Pj4gKyAgICAg ICAgICAgICBnb3RvIG91dDsKPj4+ICsgICAgIH0KPj4+ICsKPj4+ICsgICAgIGNvdW50ZXIgPSAw Owo+Pj4gKyAgICAgZXJyID0gY29udGV4dF9iYXJyaWVyX3Rhc2soY3R4LCAtMSwgbW9ja19iYXJy aWVyX3Rhc2ssICZjb3VudGVyKTsKPj4+ICsgICAgIGlmIChlcnIpIHsKPj4+ICsgICAgICAgICAg ICAgcHJfZXJyKCJGYWlsZWQgYXQgbGluZSAlZCwgZXJyPSVkXG4iLCBfX0xJTkVfXywgZXJyKTsK Pj4+ICsgICAgICAgICAgICAgZ290byBvdXQ7Cj4+PiArICAgICB9Cj4+PiArICAgICBpZiAoY291 bnRlciA9PSAwKSB7Cj4+PiArICAgICAgICAgICAgIHByX2VycigiRGlkIG5vdCByZXRpcmUgaW1t ZWRpYXRlbHkgZm9yIGFsbCBpbmFjdGl2ZSBlbmdpbmVzXG4iKTsKPj4KPj4gV2h5IHdvdWxkIHRo aXMgb25lIHJldGlyZSBpbW1lZGlhdGVseT8gSXQgd2lsbCBzZW5kIHJlcXVlc3RzIGRvd24gdGhl Cj4+IHBpcGUsIG5vPyBTbyBkb24ndCB5b3UgYWN0dWFsbHkgbmVlZCB0byB3YWl0IGZvciB0aGUg dHJhY2tlciB0byBiZQo+PiBzaWduYWxsZWQgYW5kIHRoYXQgY291bnRlciA9PSBudW1fZW5naW5l cz8KPiAKPiBOb3RoaW5nIGhhcyB1c2VkIHRoZSBjb250ZXh0IGF0IHRoaXMgcG9pbnQsIHNvIHdl IGRvbid0IGVtaXQgYSByZXF1ZXN0Cj4gb24gYW55IGVuZ2luZSwgYW5kIHRoZSBiYXJyaWVyIGNh biBiZSBpbW1lZGlhdGVseSBleGVjdXRlZC4KClllcCwgdGhhdCBpdCB1c2VzIGN0eC0+YWN0aXZl X2VuZ2luZXMgc2xpcHBlZCBteSBtaW5kLgoKPj4+ICsgICAgICAgICAgICAgZXJyID0gLUVJTlZB TDsKPj4+ICsgICAgICAgICAgICAgZ290byBvdXQ7Cj4+PiArICAgICB9Cj4+PiArCj4+PiArICAg ICBycSA9IEVSUl9QVFIoLUVOT0RFVik7Cj4+PiArICAgICB3aXRoX2ludGVsX3J1bnRpbWVfcG0o aTkxNSwgd2FrZXJlZikKPj4+ICsgICAgICAgICAgICAgcnEgPSBpOTE1X3JlcXVlc3RfYWxsb2Mo aTkxNS0+ZW5naW5lW1JDU10sIGN0eCk7Cj4+PiArICAgICBpZiAoSVNfRVJSKHJxKSkgewo+Pj4g KyAgICAgICAgICAgICBwcl9lcnIoIlJlcXVlc3QgYWxsb2NhdGlvbiBmYWlsZWQhXG4iKTsKPj4+ ICsgICAgICAgICAgICAgZ290byBvdXQ7Cj4+PiArICAgICB9Cj4+PiArICAgICBpOTE1X3JlcXVl c3RfYWRkKHJxKTsKPj4KPj4gRG9lc24ndCB0aGlzIG5lZWQgdG8gZ28gdW5kZXIgdGhlIHdha2Vy ZWYgYXMgd2VsbD8KPiAKPiBObywgd2Ugb25seSBuZWVkIHRoZSB3YWtlcmVmIHRvIHN0YXJ0ICh0 aGF0J3Mgb25seSB0byBhdm9pZCBibG9ja2luZwo+IGluc2lkZSByZXF1ZXN0X2FsbG9jIC0tLSB5 ZWFoLCB0aGF0J3Mgbm90IGV4YWN0bHkgaG93IGl0IHdvcmtzLCB3ZSdsbCBiZQo+IGJhY2sgbGF0 ZXIgdG8gZml4IHRoYXQhKS4gVGhlIHJlcXVlc3QgdGhlbiBjYXJyaWVzIHRoZSBHVCB3YWtlcmVm IHdpdGggaXQuCj4gCj4+PiArICAgICBHRU1fQlVHX09OKGxpc3RfZW1wdHkoJmN0eC0+YWN0aXZl X2VuZ2luZXMpKTsKPj4+ICsKPj4+ICsgICAgIGNvdW50ZXIgPSAwOwo+Pj4gKyAgICAgY29udGV4 dF9iYXJyaWVyX2luamVjdF9mYXVsdCA9IEJJVChSQ1MpOwo+Pj4gKyAgICAgZXJyID0gY29udGV4 dF9iYXJyaWVyX3Rhc2soY3R4LCAtMSwgbW9ja19iYXJyaWVyX3Rhc2ssICZjb3VudGVyKTsKPj4+ ICsgICAgIGNvbnRleHRfYmFycmllcl9pbmplY3RfZmF1bHQgPSAwOwo+Pj4gKyAgICAgaWYgKGVy ciA9PSAtRU5YSU8pCj4+PiArICAgICAgICAgICAgIGVyciA9IDA7Cj4+PiArICAgICBlbHNlCj4+ PiArICAgICAgICAgICAgIHByX2VycigiRGlkIG5vdCBoaXQgZmF1bHQgaW5qZWN0aW9uIVxuIik7 Cj4+PiArICAgICBpZiAoY291bnRlciAhPSAwKSB7Cj4+PiArICAgICAgICAgICAgIHByX2Vycigi SW52b2tlZCBjYWxsYmFjayBvbiBlcnJvciFcbiIpOwo+Pj4gKyAgICAgICAgICAgICBlcnIgPSAt RUlPOwo+Pj4gKyAgICAgfQo+Pj4gKyAgICAgaWYgKGVycikKPj4+ICsgICAgICAgICAgICAgZ290 byBvdXQ7Cj4+PiArCj4+PiArICAgICBjb3VudGVyID0gMDsKPj4+ICsgICAgIGVyciA9IGNvbnRl eHRfYmFycmllcl90YXNrKGN0eCwgLTEsIG1vY2tfYmFycmllcl90YXNrLCAmY291bnRlcik7Cj4+ PiArICAgICBpZiAoZXJyKSB7Cj4+PiArICAgICAgICAgICAgIHByX2VycigiRmFpbGVkIGF0IGxp bmUgJWQsIGVycj0lZFxuIiwgX19MSU5FX18sIGVycik7Cj4+PiArICAgICAgICAgICAgIGdvdG8g b3V0Owo+Pj4gKyAgICAgfQo+Pj4gKyAgICAgbW9ja19kZXZpY2VfZmx1c2goaTkxNSk7Cj4+PiAr ICAgICBpZiAoY291bnRlciA9PSAwKSB7Cj4+PiArICAgICAgICAgICAgIHByX2VycigiRGlkIG5v dCByZXRpcmUgb24gZWFjaCBhY3RpdmUgZW5naW5lc1xuIik7Cj4+PiArICAgICAgICAgICAgIGVy ciA9IC1FSU5WQUw7Cj4+PiArICAgICAgICAgICAgIGdvdG8gb3V0Owo+Pj4gKyAgICAgfQo+Pgo+ PiBUaGlzIG9uZSBpcyBpbmxpbmUgd2l0aCBteSB1bmRlcnN0YW5kaW5nLCBhbmQgdGhlIGNvbnRl eHRfYmFycmllcl90YXNrCj4+IGFyZ3VtZW50cyBhcmUgdGhlIHNhbWUgYXMgdGhlIG9uZSBhYm92 ZS4uIGhtLi4gSSBhbSBjb25mdXNlZC4KPiAKPiBUaGlzIHRpbWUgaXQgaXMgYWN0aXZlLCBzbyB3 ZSBhY3R1YWxseSBoYXZlIHRvIHdhaXQgYXMgdGhlIGJhcnJpZXIgd2FpdHMKPiBmb3IgdGhlIEdQ VSBiZWZvcmUgZmlyaW5nLgoKWWVwLgoKUmV2aWV3ZWQtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0 a28udXJzdWxpbkBpbnRlbC5jb20+CgpSZWdhcmRzLAoKVHZydGtvCgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4