From: Pavel Begunkov <asml.silence@gmail.com>
To: io-uring@vger.kernel.org, Vadim Fedorenko <vadim.fedorenko@linux.dev>
Cc: netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Paolo Abeni <pabeni@redhat.com>,
Willem de Bruijn <willemb@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
Stanislav Fomichev <sdf@fomichev.me>,
Jason Xing <kerneljasonxing@gmail.com>
Subject: Re: [PATCH v3 0/5] io_uring cmd for tx timestamps
Date: Thu, 12 Jun 2025 10:15:50 +0100 [thread overview]
Message-ID: <3ff6b1e8-ea46-47db-aa52-65f252550396@gmail.com> (raw)
In-Reply-To: <cover.1749657325.git.asml.silence@gmail.com>
On 6/12/25 10:09, Pavel Begunkov wrote:
> Vadim Fedorenko suggested to add an alternative API for receiving
> tx timestamps through io_uring. The series introduces io_uring socket
> cmd for fetching tx timestamps, which is a polled multishot request,
> i.e. internally polling the socket for POLLERR and posts timestamps
> when they're arrives. For the API description see Patch 5.
>
> It reuses existing timestamp infra and takes them from the socket's
> error queue. For networking people the important parts are Patch 1,
> and io_uring_cmd_timestamp() from Patch 5 walking the error queue.
>
> It should be reasonable to take it through the io_uring tree once
> we have consensus, but let me know if there are any concerns.
>
> v3: Add a flag to distinguish sw vs hw timestamp. skb_get_tx_timestamp()
> from Patch 1 now returns the indication of that, and in Patch 5
> it's converted into a io_uring CQE bit flag.
FWIW, it's a relatively small change, but I dropped all review tags.
Also I pruned the test I've been using (derived from the tx-timestamp
selftest). Pushed it here:
https://github.com/isilence/liburing/tree/tx-timestamp
--
Pavel Begunkov
prev parent reply other threads:[~2025-06-12 9:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 9:09 [PATCH v3 0/5] io_uring cmd for tx timestamps Pavel Begunkov
2025-06-12 9:09 ` [PATCH v3 1/5] net: timestamp: add helper returning skb's tx tstamp Pavel Begunkov
2025-06-12 21:20 ` Willem de Bruijn
2025-06-12 9:09 ` [PATCH v3 2/5] io_uring/poll: introduce io_arm_apoll() Pavel Begunkov
2025-06-12 9:09 ` [PATCH v3 3/5] io_uring/cmd: allow multishot polled commands Pavel Begunkov
2025-06-12 9:09 ` [PATCH v3 4/5] io_uring: add mshot helper for posting CQE32 Pavel Begunkov
2025-06-12 9:09 ` [PATCH v3 5/5] io_uring/netcmd: add tx timestamping cmd support Pavel Begunkov
2025-06-12 14:12 ` Jens Axboe
2025-06-12 14:26 ` Pavel Begunkov
2025-06-12 14:31 ` Jens Axboe
2025-06-12 15:01 ` Pavel Begunkov
2025-06-12 21:35 ` Willem de Bruijn
2025-06-13 18:29 ` Pavel Begunkov
2025-06-12 9:15 ` Pavel Begunkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ff6b1e8-ea46-47db-aa52-65f252550396@gmail.com \
--to=asml.silence@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=io-uring@vger.kernel.org \
--cc=kerneljasonxing@gmail.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=sdf@fomichev.me \
--cc=vadim.fedorenko@linux.dev \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.