From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: powerpc/pseries: energy driver only print message when LPAR guest
Date: Fri, 11 Aug 2017 22:19:48 +1000 (AEST) [thread overview]
Message-ID: <3xTPFw2Tvlz9t32@ozlabs.org> (raw)
In-Reply-To: <20170721111644.2a6a6610@roar.ozlabs.ibm.com>
On Fri, 2017-07-21 at 01:16:44 UTC, Nicholas Piggin wrote:
> On Thu, 20 Jul 2017 23:03:21 +1000
> Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> > Nicholas Piggin <npiggin@gmail.com> writes:
> >
> > > This driver currently reports the H_BEST_ENERGY is unsupported even
> > > when booting in a non-LPAR environment (e.g., powernv). Prevent it.
> >
> > Just delete the printk(). Users don't know what that means, and
> > developers have other better ways to detect that the hcall is missing if
> > anyone cares.
> >
> > cheers
>
> powerpc/pseries: energy driver do not print failure message
>
> This driver currently reports the H_BEST_ENERGY is unsupported (even
> when booting in a non-LPAR environment). This is not something the
> administrator can do much with, and not significant for debugging.
>
> Remove it.
>
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> Reviewed-by: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/a70a0b9f4404d8edb72ca0e0272731
cheers
prev parent reply other threads:[~2017-08-11 12:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 11:59 [PATCH] powerpc/pseries: energy driver only print message when LPAR guest Nicholas Piggin
2017-07-20 13:03 ` Michael Ellerman
2017-07-21 1:16 ` Nicholas Piggin
2017-07-21 4:35 ` Vaidyanathan Srinivasan
2017-07-21 6:33 ` Michael Ellerman
2017-07-21 8:02 ` Vaidyanathan Srinivasan
2017-08-11 12:19 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3xTPFw2Tvlz9t32@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.