From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Michael Neuling <mikey@neuling.org>
Cc: mikey@neuling.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [1/2] powerpc: Add workaround for P9 vector CI load issue
Date: Wed, 27 Sep 2017 20:32:15 +1000 (AEST) [thread overview]
Message-ID: <3y2Df80GwFz9tXw@ozlabs.org> (raw)
In-Reply-To: <20170915052549.8105-1-mikey@neuling.org>
On Fri, 2017-09-15 at 05:25:48 UTC, Michael Neuling wrote:
> POWER9 DD2.1 and earlier has an issue where some cache inhibited
> vector load will return bad data. The workaround is two part, one
> firmware/microcode part triggers HMI interrupts when hitting such
> loads, the other part is this patch which then emulates the
> instructions in Linux.
>
> The affected instructions are limited to lxvd2x, lxvw4x, lxvb16x and
> lxvh8x.
>
> When an instruction triggers the HMI, all threads in the core will be
> sent to the HMI handler, not just the one running the vector load.
>
> In general, these spurious HMIs are detected by the emulation code and
> we just return back to the running process. Unfortunately, if a
> spurious interrupt occurs on a vector load that's to normal memory we
> have no way to detect that it's spurious (unless we walk the page
> tables, which is very expensive). In this case we emulate the load but
> we need do so using a vector load itself to ensure 128bit atomicity is
> preserved.
>
> Some additional debugfs emulated instruction counters are added also.
>
> Signed-off-by: Michael Neuling <mikey@neuling.org>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Patch 1 applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/5080332c2c893118dbc18755f35c8b
cheers
prev parent reply other threads:[~2017-09-27 10:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 5:25 [PATCH 1/2] powerpc: Add workaround for P9 vector CI load issue Michael Neuling
2017-09-15 5:25 ` [PATCH 2/2] powerpc: Handle MCE on POWER9 with only DSISR bit 33 set Michael Neuling
2017-09-19 10:13 ` Balbir Singh
2017-09-21 1:50 ` Michael Neuling
2017-09-20 11:43 ` Michael Ellerman
2017-09-27 10:32 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3y2Df80GwFz9tXw@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.