All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Mahoney <jeffm@suse.com>
To: ReiserFS Mailing List <reiserfs-list@namesys.com>
Subject: [PATCHES] 2.6.1 Cleanups
Date: Mon, 12 Jan 2004 16:53:46 -0500	[thread overview]
Message-ID: <4003176A.3070901@suse.com> (raw)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hey all -

Now that the 2.6.0 hurdle has been cleared and Linus seems to be more
open to cleanup-type patches, I have these to submit for comment.

I have 4 patches, descriptions follow:
* cleanup-01-basic-cleanup
	-- This cleans up journal.c such that the ugly 50+ character
	macro/derefs that are used repeatedly are evaluated once and
	then accessed using a temporary variable. The resulting code
	should be identical and makes it quite a bit nicer to read.

* cleanup-01-sb-opts
	-- This eliminates individual #defines for superblock/mount
	options and instead uses an enum. It's not like the actual
	values of the mount options matter, and this just makes a list
	of them. Accordingly, since the values aren't apparently in the
	include, I added a BUG_ON to bail out of the value passes beyond
	the size of the mount_opts variable.

* cleanup-02-bh-bits
	-- This patch makes all the accesses for bh->b_state use the
	appropriate macros, rather than accessing them directly.

* cleanup-03-bh-cleanup
	-- This patch eliminates the local macro implementation for the
	bh->b_state accessors/mutators and uses the FNS_BUFFER
	implementation in fs.h, which automatically creates the macros
	with on line of code.

* cleanup-04-sb-journal-elimination
	-- This patch is similar to the basic-cleanup, except that it
	focuses on the use of SB_JOURNAL(super) everywhere, and replaces
	it with a local "journal" variable. Again, this makes the code
	much easier to look at.

Opinions? Comments?

Patches can be found at
ftp://ftp.suse.com/pub/people/jeffm/reiserfs/kernel-v2.6/2.6.1/

- -Jeff

I apologize if this posted twice. The first message had the patches
attached, and crossed the post size limit. I haven't received a bounce yet.

- --
Jeff Mahoney
SuSE Labs
jeffm@suse.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFAAxdqLPWxlyuTD7IRAuedAKCETcQI8uv3l2+KV2dZuuTsO3jVmQCcCaEZ
9TZxgECJvfcr/9CwHwrRLWw=
=i605
-----END PGP SIGNATURE-----

             reply	other threads:[~2004-01-12 21:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-12 21:53 Jeff Mahoney [this message]
2004-02-24  2:55 ` [PATCHES] 2.6.1 Cleanups Jeff Mahoney
2004-02-24 12:11   ` Dieter Nützel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4003176A.3070901@suse.com \
    --to=jeffm@suse.com \
    --cc=reiserfs-list@namesys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.