Re: [PATCH] zcache: fix "zcache=" kernel parameter

[Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>]

On Wednesday, July 24, 2013 01:41:57 PM Michal Hocko wrote:
> On Wed 24-07-13 12:32:32, Bartlomiej Zolnierkiewicz wrote:
> > 
> > Hi,
> > 
> > On Wednesday, July 24, 2013 12:04:41 PM Michal Hocko wrote:
> > > On Wed 24-07-13 12:02:35, Michal Hocko wrote:
> > > > I have posted a similar fix quite some time ago and I guess Greg should
> > > > already have it.
> > > 
> > > For reference https://lkml.org/lkml/2013/6/26/410
> > 
> > There was a reply from Greg:
> > 
> > 	https://lkml.org/lkml/2013/6/26/410
> 
> I guess you meant https://lkml.org/lkml/2013/6/26/569

Uh, yes.

> > and it seems that Greg's request has not been fullfilled.
> 
> Bob Liu has resent the patch (I cannot find the email in the archive).

Indeed, I've found it here:

http://comments.gmane.org/gmane.linux.kernel.mm/102484

> > Anyway Piotr's patch seems to be more complete:
> > - it also fixes case in which invalid "zcache=" option is given (returns
> >   an error value 1 while with your patch the code still erronously retuns 0)
> > - it prints information about compressor type being used when "zcache="
> >   option is used (your patch skips it due to addition of "goto out_alloc")
> 
> I do not care which one will make it I just pointed out that there is
> another patch dealing with the same and it is a question how far that
> one went.

OK.

Greg, could you please pick Piotr's patch?

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics