rebuild-tree fails in pass 2

rebuild-tree fails in pass 2

[Michael Harnois]

I am running a 2.6.1 kernel pulled from bk yesterday and using 
reiserfsprogs-3.6.11. Something happened after I rebooted that 
caused filesystem corruption which instructed me to run 
rebuild-tree. But it will not run to completion. During pass 2 
it fails with 
	Assertion `*first < bm->bm_bit_size' failed 
 
Any ideas? 
 

Re: rebuild-tree fails in pass 2

[Vitaly Fertman]

Hello,

On Thursday 15 January 2004 15:39, Michael Harnois wrote:
> I am running a 2.6.1 kernel pulled from bk yesterday and using
> reiserfsprogs-3.6.11. Something happened after I rebooted that
> caused filesystem corruption which instructed me to run
> rebuild-tree. But it will not run to completion. During pass 2
> it fails with
> 	Assertion `*first < bm->bm_bit_size' failed
>
> Any ideas?

Looks like a broken hardware (RAM?) or probably you build the 
progs not statically on one computer and then run reiserfsck on 
another one (with another glibc installed). Would you check it?

-- 
Thanks,
Vitaly Fertman

Re: rebuild-tree fails in pass 2

[Michael Harnois]

None of the above. It first failed from a Debian installation, 
then I rebuilt it from scratch and got the same error. It 
doesn't fail checking any of my other partitions, just this 
one, and it dies in the same spot each time. 
 
>Hello, 
> 
>On Thursday 15 January 2004 15:39, Michael Harnois wrote: 
>> I am running a 2.6.1 kernel pulled from bk yesterday and 
using 
>> reiserfsprogs-3.6.11. Something happened after I rebooted 
that 
>> caused filesystem corruption which instructed me to run 
>> rebuild-tree. But it will not run to completion. During 
pass 2 
>> it fails with 
>> 	Assertion `*first < bm->bm_bit_size' failed 
>> 
>> Any ideas? 
> 
>Looks like a broken hardware (RAM?) or probably you build the  
>progs not statically on one computer and then run reiserfsck 
on  
>another one (with another glibc installed). Would you check 
it? 
> 
>--  
>Thanks, 
>Vitaly Fertman 
> 

Re: rebuild-tree fails in pass 2

[Vitaly Fertman]

On Thursday 15 January 2004 16:17, Michael Harnois wrote:
> None of the above. It first failed from a Debian installation,
> then I rebuilt it from scratch and got the same error. It
> doesn't fail checking any of my other partitions, just this
> one, and it dies in the same spot each time.

ok, would you run 
	debugreiserfs -p /dev/xxx | bzip2 -c > xxx.bz2
and privide it for downloading, I will test it locally on your data.

-- 
Thanks,
Vitaly Fertman

Re: rebuild-tree fails in pass 2

[Vitaly Fertman]

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

On Thursday 15 January 2004 16:17, Michael Harnois wrote:
> None of the above. It first failed from a Debian installation,
> then I rebuilt it from scratch and got the same error. It
> doesn't fail checking any of my other partitions, just this
> one, and it dies in the same spot each time.

yes, it was a bug. The patch attached will solve the problem.

-- 
Thanks,
Vitaly Fertman

[-- Attachment #2: 3.6.11_pass2_bitmap_abort.patch --]
[-- Type: text/x-diff, Size: 636 bytes --]

diff -Nru a/reiserfsprogs/fsck/pass2.c b/reiserfsprogs/fsck/pass2.c
--- a/reiserfsprogs/fsck/pass2.c	Thu Jan 15 20:59:43 2004
+++ b/reiserfsprogs/fsck/pass2.c	Thu Jan 15 20:59:43 2004
@@ -491,7 +491,9 @@
 
     for (i = 0; i < 2; i++) {
         j = 0;
-        while (reiserfs_bitmap_find_zero_bit (fsck_uninsertables (fs), &j) == 0) {
+        while ((j < fsck_uninsertables(fs)->bm_bit_size) && 
+	       reiserfs_bitmap_find_zero_bit(fsck_uninsertables(fs), &j) == 0) 
+	{
 	    bh = bread (fs->fs_dev, j, fs->fs_blocksize);
 	    if (bh == 0) {
 	        fsck_log ("pass_2: Reading of the block (%lu) failed on the device 0x%x\n",