From: Manfred Spraul <manfred@colorfullife.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Andrew Morton <akpm@osdl.org>,
dwmw2@infradead.org,
Alexander Viro <viro@parcelfarce.linux.theplanet.co.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] kill sleep_on
Date: Sun, 18 Jan 2004 09:18:15 +0100 [thread overview]
Message-ID: <400A4147.4090405@colorfullife.com> (raw)
In-Reply-To: <1074412980.1574.40.camel@nidelv.trondhjem.org>
Trond Myklebust wrote:
>I'm not sure that taking inode->i_sem would be much of an improvement.
>Both th BKL and the inode semaphore seem superfluous to me in this
>situation.
>
I think the purpose of i_sem or lock_kernel is to protect the file
pointer. Most local filesystems use i_sem, it's noticably faster -
global vs. per-object locking.
Btw, generic_mapping_read should also lock it's accesses to f_pos: right
now it reads and writes f_pos without any locking...
--
Manfred
next prev parent reply other threads:[~2004-01-18 8:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-17 18:43 [RFC] kill sleep_on Manfred Spraul
2004-01-17 19:19 ` Arjan van de Ven
2004-01-17 19:28 ` David Woodhouse
2004-01-17 20:10 ` viro
2004-01-17 23:18 ` Trond Myklebust
2004-01-17 23:45 ` David Woodhouse
2004-01-18 6:41 ` Andrew Morton
2004-01-18 6:57 ` Trond Myklebust
2004-01-18 7:05 ` Trond Myklebust
2004-01-18 7:36 ` Andrew Morton
2004-01-18 7:44 ` Manfred Spraul
2004-01-18 8:03 ` Trond Myklebust
2004-01-18 8:18 ` Manfred Spraul [this message]
2004-01-18 17:07 ` Trond Myklebust
2004-01-18 7:54 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=400A4147.4090405@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=akpm@osdl.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.