Re: [RFC] IBM Power RAID driver (ipr)

[Douglas Gilbert <dougg@torque.net>]

Mike Anderson wrote:
> Christoph Hellwig [hch@infradead.org] wrote:
> 
>>+/**
>>+ * ipr_version_show - Show the driver version
>>+ * @dd:	device driver struct
>>+ * @buf:	buffer
>>+ * 
>>+ * Return value:
>>+ * 	number of bytes printed to buffer
>>+ **/
>>+static ssize_t ipr_version_show(struct device_driver *dd, char *buf)
>>+{
>>+	return snprintf(buf, PAGE_SIZE, "%s\n", IPR_DRIVER_VERSION);
>>+}
>>+
>>+static DRIVER_ATTR(version, S_IRUGO, ipr_version_show, NULL);
>>
>>Please don't do this in sysfs.  We're still hoping for a MODULE_VERSION
>>macro, but every driver crafting it's own version telling mechanism
>>doesn't scale.
>>
> 
> 
> This is my fault. We recommended not to include procfs info in this
> driver and pointed to sysfs. Do we have a timeline on MODULE_VERSION?

... and will MODULE_VERSION be defined when the driver is built in?

Doug Gilbert