From: Bob Doyle <doyle@primenet.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-scsi@vger.kernel.org
Subject: Re: BusLogic update - take 2
Date: Wed, 21 Jan 2004 20:45:19 -0700 [thread overview]
Message-ID: <400F474F.917B0AC0@primenet.com> (raw)
In-Reply-To: 20040121134732.B29605@infradead.org
Christoph Hellwig wrote:
> What's this:?
>
> +#ifndef FAILURE
> +#define FAILURE (-1)
> +#endif
>
> else the patch looks okay to me
The BusLogic.c code does a #include "FlashPoint.c" which conditionally defines
FAILURE when CONFIG_SCSI_OMIT_FLASHPOINT is not defined...
Eventually I'd like to get rid of that stupid include, compile the BusLogic
and FlashPoint drivers separately, and have the BusLogic module conditionally
load FlashPoint module - or something.
I'm not sure I have the stomach to touch the FlashPoint code.
Bob.
prev parent reply other threads:[~2004-01-22 3:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-15 5:13 BusLogic update - take 2 Bob Doyle
2004-01-21 13:47 ` Christoph Hellwig
2004-01-22 3:45 ` Bob Doyle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=400F474F.917B0AC0@primenet.com \
--to=doyle@primenet.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.