All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manfred Spraul <manfred@colorfullife.com>
To: " (Walter Harms)" <WHarms@bfs.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: mm/slab.c: linux 2.6.1 fix 2 unguarded kmalloc and a PAGE_SHIFT
Date: Sun, 25 Jan 2004 19:16:23 +0100	[thread overview]
Message-ID: <401407F7.5020102@colorfullife.com> (raw)

Hi Walter,

>this fixes catches 2 unguarded kmallocs() and changes a statement so that PAGE_SHIFT \
>>20 causes a warning.  At least sparc64 is prepared for a  PAGE_SHIFT >20.
>  
>
Why should a page shift above 20 generate a warning?

The two unguarded kmallocs are obivously wrong, but I'd prefer to guard 
them with __GFP_NOFAIL.

--
    Manfred


             reply	other threads:[~2004-01-25 18:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-25 18:16 Manfred Spraul [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-01-25 14:02 mm/slab.c: linux 2.6.1 fix 2 unguarded kmalloc and a PAGE_SHIFT Walter Harms
2004-01-25 18:11 ` Brian Gerst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=401407F7.5020102@colorfullife.com \
    --to=manfred@colorfullife.com \
    --cc=WHarms@bfs.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.