From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v2 04/16] Make igb_uio compilation optional
Date: Tue, 27 May 2014 10:49:01 +0200 [thread overview]
Message-ID: <4015459.eKTdkh5M37@xps13> (raw)
In-Reply-To: <DF2A19295B96364286FEB7F3DDA27A46F69410-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
Hi HuilongX,
I have few comments.
2014-05-27 02:43, Xu, HuilongX:
> Currently, igb_uio is always compiled. Some Linux distribution may
> not want to include igb_uio by default, so we need to make sure that
> igb_uio compilation can be optional.
1) When replying to an email, there should be "> " in front of lines you have
not written. Here, it's not easy to see what you are replying.
> Signed-off-by: Anatoly Burakov
> <anatoly.burakov-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org<mailto:anatoly.burakov-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>>
> Test-by: HuilongX Xu <huilongx.xu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org<mailto:huilongx.xu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>>
> Compile
> pass
>
> >>Compile OS: FC20 x86_64
> >>Kernel version: 3.13.6-200
> >>GCC version: 4.8.2
> >>Server: Crownpass
2) Please do not copy all the patch if you have nothing specific to say about
it.
--
Thomas
next prev parent reply other threads:[~2014-05-27 8:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 2:43 [PATCH v2 04/16] Make igb_uio compilation optional Xu, HuilongX
[not found] ` <DF2A19295B96364286FEB7F3DDA27A46F69410-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-05-27 8:49 ` Thomas Monjalon [this message]
2014-05-27 8:57 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2014-05-01 11:05 [PATCH 00/16] [RFC] [VFIO] Add VFIO support to DPDK Burakov, Anatoly
[not found] ` <C6ECDF3AB251BE4894318F4E45123697592AA9BE-kPTMFJFq+rF9qrmMLTLiibfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-05-19 15:51 ` [PATCH v2 04/16] Make igb_uio compilation optional Anatoly Burakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4015459.eKTdkh5M37@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.