Re: [PATCH] 2.6.2-rc2 - MPT Fusion driver 3.00.02 update

[Douglas Gilbert <dougg@torque.net>]

Jeremy Higdon wrote:
> On Mon, Jan 26, 2004 at 07:34:13PM +0000, Christoph Hellwig wrote:
> 
>>On Mon, Jan 26, 2004 at 11:05:26AM -0600, James Bottomley wrote:
>>
>>>>I had avoided it due the comments in the code
>>>>from sralston and pdelaney about sg interface 
>>>>gererating wrong direction in some cases.  
>>>
>>>If you find a problem, I'll fix the generic code...
>>
>>I think it's just very old comments.  We had such a problem in early 2.4
>>kernels, but it has been fixed for ages.  If it wasn't most of the scsi
>>drivers would have a big problem.
> 
> 
> Aren't there three interfaces for sg, or did the early ones go away
> in 2.6?  I recall that we ran into trouble with sg setting the
> direction incorrectly in 2.4 kernels when using older interface,
> I think.

Jeremy,
I can't see any such report in my changelogs for the sg
driver during the lk 2.4 series. What was difficult with
the older sg interface (sg_header based) was setting the
command length as this was "guessed" from the first 3 bits
of the opcode (SCSI_IOCTL_SEND_COMMAND ioctl still does this).

Doug Gilbert