From: Gabriele Mazzotta <gabriele.mzt@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: stripathi@apm.com, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: Ignore spurious PHY events on LPM policy change
Date: Sat, 25 Apr 2015 19:57:18 +0200 [thread overview]
Message-ID: <4018340.TCLCYqQ7qt@xps13> (raw)
In-Reply-To: <20150425153751.GA31335@htj.duckdns.org>
On Saturday 25 April 2015 11:37:51 Tejun Heo wrote:
> I thought more about it and it's weird to have ATA_LFLAG_CHANGED and
> last_lpm_change timestamp in libata core side and then open-code the
> actual logic in ahci. How about implementing a generic helper, say,
> bool sata_lpm_ignore_phy_events(link) in libata core and use it in
> specific drivers? It can test both the current lpm_policy and the
> timeout (preferably a separate patch to introduce the function and
> factor out lpm policy testing).
I agree. I'm now going to send the revised patches, thanks for all
the suggestions.
Gabriele
prev parent reply other threads:[~2015-04-25 17:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 19:37 SATA link power management issues Gabriele Mazzotta
2015-01-09 22:00 ` Tejun Heo
2015-01-09 22:02 ` Tejun Heo
2015-01-09 22:05 ` Tejun Heo
2015-01-09 22:50 ` Gabriele Mazzotta
2015-01-12 13:16 ` Tejun Heo
2015-01-12 17:03 ` Gabriele Mazzotta
2015-01-12 17:07 ` Tejun Heo
2015-01-12 17:15 ` Gabriele Mazzotta
2015-01-09 22:40 ` Gabriele Mazzotta
[not found] ` <CAOHikRDTgVWL7_WUS3Yvce01GyP5TcyRm8ojfAyTHLTZ7xiR7A@mail.gmail.com>
2015-01-12 17:16 ` Suman Tripathi
2015-01-12 20:26 ` Gabriele Mazzotta
[not found] ` <CAOHikRCp=m6tgKEmdg2pLj=XB2ugCGhj0rkeqCzF2+DPR8O9sw@mail.gmail.com>
2015-01-12 20:36 ` Gabriele Mazzotta
[not found] ` <CAOHikRC43JBMwCahBqT1znJLBnbr3Ui+szKhVQoK8cpfapTQyg@mail.gmail.com>
2015-01-12 20:54 ` Gabriele Mazzotta
2015-01-12 23:05 ` Gabriele Mazzotta
2015-02-22 20:53 ` Gabriele Mazzotta
2015-04-20 20:02 ` Gabriele Mazzotta
2015-04-21 15:31 ` Tejun Heo
2015-04-21 20:29 ` Gabriele Mazzotta
2015-04-21 20:56 ` Tejun Heo
2015-04-21 21:44 ` Gabriele Mazzotta
2015-04-24 21:44 ` Tejun Heo
2015-04-25 9:34 ` [PATCH] libata: Ignore spurious PHY events on LPM policy change Gabriele Mazzotta
2015-04-25 15:37 ` Tejun Heo
2015-04-25 17:57 ` Gabriele Mazzotta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4018340.TCLCYqQ7qt@xps13 \
--to=gabriele.mzt@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stripathi@apm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.