From: Example <example@example.com>
To: GOTO Masanori <gotom@debian.or.jp>, linux-kernel@vger.kernel.org
Subject: Re: [uPATCH] refuse plain ufs mount
Date: Wed, 28 Jan 2004 22:24:30 +0000 [thread overview]
Message-ID: <4018369E.6090105@example.com> (raw)
Hi,
There's a semantic change introduced by this patch.
I don't know enough about UFS to call it a bug, but it
certainly looks suspicious.
>--- fs/ufs/super.c.org 2003-10-20 12:50:24.000000000 +0900
>+++ fs/ufs/super.c 2004-01-27 13:26:05.000000000 +0900
>@@ -516,7 +516,7 @@
> printk("wrong mount options\n");
> goto failed;
> }
>- if (!(sbi->s_mount_opt & UFS_MOUNT_UFSTYPE)) {
>+ if (!(sbi->s_mount_opt & UFS_MOUNT_UFSTYPE) && !silent) {
> printk("You didn't specify the type of your ufs filesystem\n\n"
> "mount -t ufs -o ufstype="
> "sun|sunx86|44bsd|old|hp|nextstep|netxstep-cd|openstep ...\n\n"
>@@ -575,7 +575,7 @@
> uspi->s_sbsize = super_block_size = 2048;
> uspi->s_sbbase = 0;
> flags |= UFS_DE_OLD | UFS_UID_OLD | UFS_ST_OLD | UFS_CG_OLD;
>- if (!(sb->s_flags & MS_RDONLY)) {
>+ if (!(sb->s_flags & MS_RDONLY) && !silent) {
> printk(KERN_INFO "ufstype=old is supported read-only\n");
> sb->s_flags |= MS_RDONLY;
If "silent" is set, this variable assignment is skipped. I
would have thought that the assignment should happen, and only
the printk() should be skipped.
> }
>@@ -589,7 +589,7 @@
> uspi->s_sbsize = super_block_size = 2048;
> uspi->s_sbbase = 0;
> flags |= UFS_DE_OLD | UFS_UID_OLD | UFS_ST_OLD | UFS_CG_OLD;
>- if (!(sb->s_flags & MS_RDONLY)) {
>+ if (!(sb->s_flags & MS_RDONLY) && !silent) {
> printk(KERN_INFO "ufstype=nextstep is supported read-only\n");
> sb->s_flags |= MS_RDONLY;
Same here.
> }
>@@ -603,7 +603,7 @@
> uspi->s_sbsize = super_block_size = 2048;
> uspi->s_sbbase = 0;
> flags |= UFS_DE_OLD | UFS_UID_OLD | UFS_ST_OLD | UFS_CG_OLD;
>- if (!(sb->s_flags & MS_RDONLY)) {
>+ if (!(sb->s_flags & MS_RDONLY) && !silent) {
> printk(KERN_INFO "ufstype=nextstep-cd is supported read-only\n");
> sb->s_flags |= MS_RDONLY;
And again.
> }
>@@ -617,7 +617,7 @@
> uspi->s_sbsize = super_block_size = 2048;
> uspi->s_sbbase = 0;
> flags |= UFS_DE_44BSD | UFS_UID_44BSD | UFS_ST_44BSD | UFS_CG_44BSD;
>- if (!(sb->s_flags & MS_RDONLY)) {
>+ if (!(sb->s_flags & MS_RDONLY) && !silent) {
> printk(KERN_INFO "ufstype=openstep is supported read-only\n");
> sb->s_flags |= MS_RDONLY;
Another one.
> }
>@@ -631,13 +631,14 @@
> uspi->s_sbsize = super_block_size = 2048;
> uspi->s_sbbase = 0;
> flags |= UFS_DE_OLD | UFS_UID_OLD | UFS_ST_OLD | UFS_CG_OLD;
>- if (!(sb->s_flags & MS_RDONLY)) {
>+ if (!(sb->s_flags & MS_RDONLY) && !silent) {
> printk(KERN_INFO "ufstype=hp is supported read-only\n");
> sb->s_flags |= MS_RDONLY;
And again.
> }
> break;
> default:
>- printk("unknown ufstype\n");
>+ if (!silent)
>+ printk("unknown ufstype\n");
> goto failed;
> }
>
>@@ -687,7 +688,8 @@
> uspi->s_sbbase += 8;
> goto again;
> }
>- printk("ufs_read_super: bad magic number\n");
>+ if (!silent)
>+ printk("ufs_read_super: bad magic number\n");
> goto failed;
>
> magic_found:
Kind regards,
Jon
next reply other threads:[~2004-01-28 22:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-28 22:24 Example [this message]
2004-01-29 0:13 ` [uPATCH] refuse plain ufs mount GOTO Masanori
-- strict thread matches above, loose matches on Subject: below --
2004-01-27 4:07 Andries.Brouwer
2004-01-27 5:04 ` GOTO Masanori
2004-01-27 6:15 ` Linus Torvalds
2004-01-27 1:56 Andries.Brouwer
2004-01-27 2:09 ` Linus Torvalds
2004-01-25 0:17 Andries.Brouwer
2004-01-27 1:43 ` GOTO Masanori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4018369E.6090105@example.com \
--to=example@example.com \
--cc=gotom@debian.or.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.