From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCHv3] batman-adv: Introduce forward packet creation helper
Date: Mon, 20 Jun 2016 20:05:32 +0200 [thread overview]
Message-ID: <4019482.FMBfOuWKPo@sven-edge> (raw)
In-Reply-To: <20160620175803.GB16638@otheros>
[-- Attachment #1: Type: text/plain, Size: 808 bytes --]
On Monday 20 June 2016 19:58:03 Linus Lüssing wrote:
[...]
> > > @@ -478,20 +546,16 @@ int batadv_add_bcast_packet_to_list(struct batadv_priv *bat_priv,
[...]
> Regarding these two goto's, usually using a "return" directly instead of a
> "goto out" is better, I agree. For these two cases I think I would
> prefer keeping it that way, because it's not a simple return but a
> return of a macro value. Having NETDEV_TX_OK and NETDEV_TX_BUSY
> each only once in a function makes it easier to spot the good or
> bad cases, I think?
>
> Or maybe I could rename "out" and "packet_free" to "err" and
> "err_packet_free" to make the error cases even more visible?
Hm, not sure if this is really required but I honestly like the
names "err" and "err_packet_free" right now :)
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-06-20 18:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 21:19 [B.A.T.M.A.N.] [PATCHv3] batman-adv: Introduce forward packet creation helper Linus Lüssing
2016-06-19 11:00 ` Sven Eckelmann
2016-06-20 17:58 ` Linus Lüssing
2016-06-20 18:05 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4019482.FMBfOuWKPo@sven-edge \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.