Re: [PATCH v4 26/34] omap3isp: Add information on external subdev to struct isp_pipeline

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Sakari,

Thanks for the patch.

On Friday 02 March 2012 19:30:34 Sakari Ailus wrote:
> Add pointer to external subdev, pixel rate of the external subdev and bpp of
> the format to struct isp_pipeline.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
> ---
>  drivers/media/video/omap3isp/ispvideo.h |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/media/video/omap3isp/ispvideo.h
> b/drivers/media/video/omap3isp/ispvideo.h index d91bdb91..b198723 100644
> --- a/drivers/media/video/omap3isp/ispvideo.h
> +++ b/drivers/media/video/omap3isp/ispvideo.h
> @@ -102,6 +102,9 @@ struct isp_pipeline {
>  	bool do_propagation; /* of frame number */
>  	bool error;
>  	struct v4l2_fract max_timeperframe;
> +	struct v4l2_subdev *external;
> +	unsigned int external_rate;
> +	int external_bpp;

unsigned int ? :-)

With that change,

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>  };
> 
>  #define to_isp_pipeline(__e) \

-- 
Regards,

Laurent Pinchart