All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Veeck <michael.veeck@gmx.net>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Kernel-janitors] [PATCH] drivers/net/acenic.c MIN/MAX removal
Date: Sat, 07 Feb 2004 17:35:05 +0000	[thread overview]
Message-ID: <402521C9.9050402@gmx.net> (raw)
In-Reply-To: <40250629.3030004@gmx.net>



Jeff Garzik schrieb:
> Michael Veeck wrote:
> 
>> Hi!
>> Patch (against 2.6.3-rc1) removes unnecessary min/max macros and 
>> changes calls to use kernel.h macros instead.
>> Feedback always welcome
>> Michael
>>
>>
>> ------------------------------------------------------------------------
>>
>> --- linux-2.6.2.org/drivers/net/acenic.c    2004-02-07 
>> 15:25:57.000000000 +0100
>> +++ linux-2.6.2.new/drivers/net/acenic.c    2004-02-07 
>> 15:33:24.286033896 +0100
>> @@ -335,10 +335,6 @@
>>  #define ACE_PROBE_ARG                struct net_device *dev
>>  #endif
>>  
>> -#ifndef min_t
>> -#define min_t(type,a,b)    (((a)<(b))?(a):(b))
>> -#endif
> 
> 
> 
> Read the code you're patching :)
> 
> You're killing compat code the driver author added.
> 
>     Jeff
> 

Ah, that didnt came into my mind. But since #ifndef min_t doesnt seem to 
be in any of the "#if LINUX_VERSION_CODE >= " why not put it in the 
appropiate one?

Do you know when the min_t was introduced in include/linux/kernel.h ?

	Veeck

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2004-02-07 17:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-07 15:37 [Kernel-janitors] [PATCH] drivers/net/acenic.c MIN/MAX removal Michael Veeck
2004-02-07 16:30 ` Jeff Garzik
2004-02-07 17:35 ` Michael Veeck [this message]
2004-02-16 18:33 ` Randy.Dunlap
2004-02-17 12:53 ` Michael Veeck
2004-04-06 23:45 ` Michael Veeck
2004-04-07 23:16 ` Randy.Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=402521C9.9050402@gmx.net \
    --to=michael.veeck@gmx.net \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.