From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264356AbUBHTfM (ORCPT ); Sun, 8 Feb 2004 14:35:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264411AbUBHTfM (ORCPT ); Sun, 8 Feb 2004 14:35:12 -0500 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:18660 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S264356AbUBHTfI (ORCPT ); Sun, 8 Feb 2004 14:35:08 -0500 Message-ID: <40268F5E.4050609@pobox.com> Date: Sun, 08 Feb 2004 14:34:54 -0500 From: Jeff Garzik User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030703 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Geert Uytterhoeven CC: Adrian Bunk , Linus Torvalds , Andrew Morton , Linux Kernel Development , Greg KH Subject: Re: [PATCH 405] Amiga Hydra Ethernet new driver model References: <200402081528.i18FSTrV026999@callisto.of.borg> <20040208184705.GW7388@fs.tum.de> In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Geert Uytterhoeven wrote: > But a quick look shows that very few drivers seem to mark their ID table array > __devinitdata... Yes, this highlights a recent problem with CONFIG_HOTPLUG. These markers were removed when the "add PCI ids to your table dynamically" patch was added in 2.5.x. The patch didn't require CONFIG_HOTPLUG, and fun ensued. This got fixed (IIRC), but also many drivers had their __devinitdata markers removed. This is a fuzzy area where Greg loves to make the case for removing CONFIG_HOTPLUG completely :) Jeff