From: Greg Banks <gnb@melbourne.sgi.com>
To: James Pearson <james-p@moving-picture.com>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>,
Linux NFS Mailing List <nfs@lists.sourceforge.net>
Subject: Re: [PATCH] SGI 882960: Busy inodes after unmount, oops
Date: Mon, 09 Feb 2004 18:46:36 +1100 [thread overview]
Message-ID: <40273ADC.58AE1887@melbourne.sgi.com> (raw)
In-Reply-To: 402239C3.AD21DDAD@moving-picture.com
James Pearson wrote:
>
> I notice this patch doesn't apply cleanly with Trond's fix_unlink patch
The second smaller version applies cleanly over fix_unlink.dif (with a 6 line
offset).
> - can the two patches live together?
Yes. But...
If all you want is to prevent busy inodes and the subsequent oops, my patch
will do that in all cases. As discussed earlier, Trond's patch still allows
busy inodes if the mount is "intr" and the last close is interrupted. I have
a small test case which triggers this on a kernel with only Trond's patch.
OTOH, Trond's patch serialises the last close so that umount cannot proceed
until the .nfsXXX file is removed, which greatly reduces the chances of
short-lived mounts leaving turds on the server. This is obviously a good
thing.
So I would recommend using both patches.
Greg.
--
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
I don't speak for SGI.
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
prev parent reply other threads:[~2004-02-09 7:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-04 7:12 [PATCH] SGI 882960: Busy inodes after unmount, oops Greg Banks
2004-02-04 10:42 ` Olaf Kirch
2004-02-04 22:59 ` Greg Banks
2004-02-04 12:09 ` Olaf Kirch
2004-02-04 22:41 ` Greg Banks
2004-02-05 16:15 ` Olaf Kirch
2004-02-05 22:23 ` Greg Banks
2004-02-06 5:50 ` Greg Banks
2004-02-13 16:26 ` canon
2004-02-04 14:24 ` raven
2004-02-04 22:56 ` Greg Banks
2004-02-05 12:40 ` James Pearson
2004-02-09 7:46 ` Greg Banks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40273ADC.58AE1887@melbourne.sgi.com \
--to=gnb@melbourne.sgi.com \
--cc=james-p@moving-picture.com \
--cc=nfs@lists.sourceforge.net \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.