From: Greg Banks <gnb@melbourne.sgi.com>
To: Olaf Kirch <okir@suse.de>
Cc: Christoph Hellwig <hch@lst.de>,
netdev@oss.sgi.com, nfs@lists.sourceforge.net
Subject: Re: [NFS] [PATCH][RFC] use completions instead of sleep_on for rpciod
Date: Tue, 10 Feb 2004 12:52:18 +1100 [thread overview]
Message-ID: <40283952.6093F19D@melbourne.sgi.com> (raw)
In-Reply-To: 20040209102801.GC21364@suse.de
Olaf Kirch wrote:
>
> [...] The code in fs/nfs/unlink.c is probably also racy
> without BKL.
I had cause to poke around there recently, and it's *definitely* racy
without BKL. That file would benefit from several modernisations:
1. move the list of nfs_unlinkdata from a global to a field in nfs_server
2. add a lock in nfs_server for it instead of implicit BKL in
nfs_complete_unlink, nfs_async_unlink, nfs_put_unlinkdata
3. use proper list.h lists
> So if you remove the sunrpc BKL be prepared for lots and lots
> of bug reports :)
Yes but it's worth doing, especially serverside.
Greg.
--
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
I don't speak for SGI.
next prev parent reply other threads:[~2004-02-10 1:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-07 14:44 [PATCH][RFC] use completions instead of sleep_on for rpciod Christoph Hellwig
2004-02-08 20:43 ` David S. Miller
2004-02-09 10:28 ` Olaf Kirch
2004-02-09 11:38 ` [PATCH][RFC] sleep_on fixes for lockd Christoph Hellwig
2004-02-09 20:48 ` [NFS] [PATCH][RFC] use completions instead of sleep_on forrpciod trond.myklebust
2004-02-09 20:48 ` trond.myklebust
2004-02-09 21:00 ` David S. Miller
2004-02-10 9:15 ` Olaf Kirch
2004-02-10 11:47 ` trond.myklebust
2004-02-10 11:47 ` trond.myklebust
2004-02-10 1:52 ` Greg Banks [this message]
2004-02-10 9:18 ` [NFS] [PATCH][RFC] use completions instead of sleep_on for rpciod Olaf Kirch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40283952.6093F19D@melbourne.sgi.com \
--to=gnb@melbourne.sgi.com \
--cc=hch@lst.de \
--cc=netdev@oss.sgi.com \
--cc=nfs@lists.sourceforge.net \
--cc=okir@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.