All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ulrich Drepper <drepper@redhat.com>
To: Andrew Morton <akpm@osdl.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: invalid fadvise parameter
Date: Thu, 12 Feb 2004 22:35:48 -0800	[thread overview]
Message-ID: <402C7044.6050409@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 450 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

The len parameter for fadvise has a signed type and negative values
passed must be rejected.  The attached patch does the job.

- --
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQFALHBE2ijCOnn/RHQRAlFAAJ99cQ5raRpz2OuSRSi3Xf4WdYuPvwCgycGi
0QZLMcHfqOcxjEzDl2tGDuA=
=igyM
-----END PGP SIGNATURE-----

[-- Attachment #2: d-fadvise --]
[-- Type: text/plain, Size: 259 bytes --]

--- mm/fadvise.c	2004-01-19 20:09:03.000000000 -0800
+++ mm/fadvise.c-new	2004-02-12 22:33:32.000000000 -0800
@@ -33,7 +33,7 @@
 		return -EBADF;
 
 	mapping = file->f_mapping;
-	if (!mapping) {
+	if (!mapping || len < 0) {
 		ret = -EINVAL;
 		goto out;
 	}

                 reply	other threads:[~2004-02-13  6:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=402C7044.6050409@redhat.com \
    --to=drepper@redhat.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.