All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Mika Penttilä" <mika.penttila@kolumbus.fi>
To: James Morris <jmorris@redhat.com>
Cc: "David S. Miller" <davem@redhat.com>,
	Harald Welte <laforge@netfilter.org>,
	netdev@oss.sgi.com, Stephen Smalley <sds@epoch.ncsc.mil>
Subject: Re: [PATCH] Fix checksum bug for multicast/broadcast packets on postrouting hook
Date: Mon, 16 Feb 2004 08:43:46 +0200	[thread overview]
Message-ID: <403066A2.30705@kolumbus.fi> (raw)
In-Reply-To: <Xine.LNX.4.44.0402152048510.14031-100000@thoron.boston.redhat.com>



James Morris wrote:

>On Sun, 15 Feb 2004, Mika Penttilä wrote:
>
>  
>
>>ah, sorry, I see your point now. Maybe this copy should be in 
>>skb_checksum_help() ?
>>    
>>
>
>No, it's not needed by all callers, and is just a does-one-thing helper 
>function.
>
>
>- James
>
It is needed for cloned skbs, so check for this should go in 
skb_checksum_help().

--Mika

  reply	other threads:[~2004-02-16  6:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-14 18:37 [PATCH] Fix checksum bug for multicast/broadcast packets on postrouting hook James Morris
2004-02-14 18:37 ` Harald Welte
2004-02-14 19:07 ` Mika Penttilä
2004-02-14 23:00   ` David S. Miller
2004-02-15  6:09   ` James Morris
2004-02-15  9:34     ` Mika Penttilä
2004-02-15 13:03       ` James Morris
2004-02-15 13:40         ` Mika Penttilä
2004-02-15 14:03           ` James Morris
2004-02-15 16:00             ` Mika Penttilä
2004-02-16  1:50               ` James Morris
2004-02-16  6:43                 ` Mika Penttilä [this message]
2004-02-16 13:45                   ` James Morris
2004-02-19  1:24                     ` David S. Miller
2004-02-23 22:19                       ` James Morris
2004-02-29  5:50                         ` David S. Miller
2004-02-17 15:54     ` Harald Welte
2004-02-17 20:35       ` James Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=403066A2.30705@kolumbus.fi \
    --to=mika.penttila@kolumbus.fi \
    --cc=davem@redhat.com \
    --cc=jmorris@redhat.com \
    --cc=laforge@netfilter.org \
    --cc=netdev@oss.sgi.com \
    --cc=sds@epoch.ncsc.mil \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.