All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <piggin@cyberone.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: Nikita Danilov <Nikita@Namesys.COM>, linux-mm@kvack.org
Subject: [PATCH] 2.6.3-rc3-mm1: align scan_page per node
Date: Mon, 16 Feb 2004 23:45:58 +1100	[thread overview]
Message-ID: <4030BB86.8060206@cyberone.com.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 92 bytes --]

Ok ok, I'll do it... is this the right way to go about it?
I'm assuming it is worth doing?


[-- Attachment #2: vm-align-scan_page.patch --]
[-- Type: text/plain, Size: 1211 bytes --]

 linux-2.6-npiggin/mm/page_alloc.c |   12 +++++++++---
 1 files changed, 9 insertions(+), 3 deletions(-)

diff -puN mm/page_alloc.c~vm-align-scan_page mm/page_alloc.c
--- linux-2.6/mm/page_alloc.c~vm-align-scan_page	2004-02-16 22:52:26.000000000 +1100
+++ linux-2.6-npiggin/mm/page_alloc.c	2004-02-16 23:41:06.000000000 +1100
@@ -1217,8 +1217,14 @@ void __init memmap_init_zone(struct page
 	memmap_init_zone((start), (size), (nid), (zone), (start_pfn))
 #endif
 
-/* dummy pages used to scan active lists */
-static struct page scan_pages[MAX_NUMNODES][MAX_NR_ZONES];
+/*
+ * Dummy pages used to scan active lists. It would be cleaner if these
+ * could be part of struct zone directly, but include dependencies currently
+ * prevent that.
+ */
+static struct {
+	struct page zone[MAX_NR_ZONES];
+} ____cacheline_aligned scan_pages[MAX_NUMNODES];
 
 /*
  * Set up the zone data structures:
@@ -1299,7 +1305,7 @@ static void __init free_area_init_core(s
 		zone->nr_inactive = 0;
 
 		/* initialize dummy page used for scanning */
-		scan_page = &scan_pages[nid][j];
+		scan_page = &(scan_pages[nid].zone[j]);
 		zone->scan_page = scan_page;
 		memset(scan_page, 0, sizeof *scan_page);
 		scan_page->flags =

_

             reply	other threads:[~2004-02-16 12:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-16 12:45 Nick Piggin [this message]
2004-02-16 13:06 ` [PATCH] 2.6.3-rc3-mm1: align scan_page per node Nikita Danilov
2004-02-16 15:47 ` Martin J. Bligh
2004-02-16 17:57   ` Andrew Morton
2004-02-16 18:36     ` Martin J. Bligh
2004-02-16 18:42       ` Christoph Hellwig
2004-02-16 18:45         ` Andrew Morton
2004-02-16 18:44       ` Andrew Morton
2004-02-16 18:52         ` Martin J. Bligh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4030BB86.8060206@cyberone.com.au \
    --to=piggin@cyberone.com.au \
    --cc=Nikita@Namesys.COM \
    --cc=akpm@osdl.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.