From: Marek Vasut <marex@denx.de>
To: Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de, Adam Ford <aford173@gmail.com>,
Breno Lima <breno.lima@nxp.com>,
Francesco Montefoschi <francesco.montefoschi@udoo.org>,
Ian Ray <ian.ray@gehealthcare.com>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Peng Fan <peng.fan@nxp.com>, Sean Anderson <seanga2@gmail.com>,
Simon Glass <sjg@chromium.org>,
u-boot@dh-electronics.com, Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH] ARM: imx: soc: Select default TEXT_BASE for i.MX6
Date: Sun, 20 Oct 2024 04:25:38 +0200 [thread overview]
Message-ID: <403105c3-e432-4d1d-a986-b81ca786b6d5@denx.de> (raw)
In-Reply-To: <20241020002701.GC4959@bill-the-cat>
On 10/20/24 2:27 AM, Tom Rini wrote:
> On Sun, Oct 20, 2024 at 12:09:03AM +0200, Marek Vasut wrote:
>
>> Select default U-Boot and SPL text base for the i.MX6 SoC. The U-Boot
>> and SPL text base is picked as the one used by various i.MX6 boards.
>> Update all the boards.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
> [snip]
>> diff --git a/arch/arm/mach-imx/mx6/Kconfig b/arch/arm/mach-imx/mx6/Kconfig
>> index 1f8022ee685..10b19984143 100644
>> --- a/arch/arm/mach-imx/mx6/Kconfig
>> +++ b/arch/arm/mach-imx/mx6/Kconfig
>> @@ -15,6 +15,13 @@ config MX6
>> select GPT_TIMER if !MX6UL && !MX6ULL
>> imply CMD_FUSE
>>
>> +config TEXT_BASE
>> + default 0x17800000
>> +
>> +config SPL_TEXT_BASE
>> + depends on SPL
>> + default 0x00908000
>
> Please do these in Kconfig and common/spl/Kconfig with the other
> SoC-wide default values, thanks.
There are many examples which do it in arch/$ARCH/$SOC , imx7 does it
already, so ... why Kconfig instead ?
$ git grep config.TEXT_BASE
Kconfig:config TEXT_BASE
arch/arm/mach-apple/Kconfig:config TEXT_BASE
arch/arm/mach-aspeed/Kconfig:config TEXT_BASE
arch/arm/mach-imx/mx7/Kconfig:config TEXT_BASE
arch/arm/mach-ipq40xx/Kconfig:config TEXT_BASE
arch/arm/mach-npcm/Kconfig:config TEXT_BASE
arch/arm/mach-owl/Kconfig:config TEXT_BASE
arch/arm/mach-rockchip/Kconfig:config TEXT_BASE
arch/arm/mach-rockchip/rk3308/Kconfig:config TEXT_BASE
arch/arm/mach-rockchip/rk3568/Kconfig:config TEXT_BASE
arch/arm/mach-rockchip/rk3588/Kconfig:config TEXT_BASE
arch/arm/mach-rockchip/rv1126/Kconfig:config TEXT_BASE
arch/arm/mach-socfpga/Kconfig:config TEXT_BASE
arch/arm/mach-stm32mp/Kconfig.13x:config TEXT_BASE
arch/arm/mach-stm32mp/Kconfig.15x:config TEXT_BASE
arch/arm/mach-stm32mp/Kconfig.25x:config TEXT_BASE
(CC list clipped, sorry if someone got dropped)
next prev parent reply other threads:[~2024-10-20 2:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-19 22:09 [PATCH] ARM: imx: soc: Select default TEXT_BASE for i.MX6 Marek Vasut
2024-10-20 0:27 ` Tom Rini
2024-10-20 2:25 ` Marek Vasut [this message]
2024-10-20 2:55 ` Tom Rini
2024-10-20 4:57 ` Marek Vasut
2024-10-20 20:16 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=403105c3-e432-4d1d-a986-b81ca786b6d5@denx.de \
--to=marex@denx.de \
--cc=aford173@gmail.com \
--cc=breno.lima@nxp.com \
--cc=festevam@gmail.com \
--cc=francesco.montefoschi@udoo.org \
--cc=ian.ray@gehealthcare.com \
--cc=marcel.ziswiler@toradex.com \
--cc=peng.fan@nxp.com \
--cc=seanga2@gmail.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@dh-electronics.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.