From: Brian King <brking@us.ibm.com>
To: Matthew Dharm <mdharm-scsi@one-eyed-alien.net>
Cc: "Sachin Mhatre (smhatre)" <smhatre@cisco.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] Midlayer initiated START_UNIT
Date: Tue, 17 Feb 2004 08:27:22 -0600 [thread overview]
Message-ID: <403224CA.2050107@us.ibm.com> (raw)
In-Reply-To: 20040217080446.GA23112@one-eyed-alien.net
Matthew Dharm wrote:
> Umm... I hope that the issuing of START_UNIT will only occur in very
> narrowly defined cases.
>
> If you just issue START_UNIT semi-arbitrarily, you'll break most USB
> devices.
And the patch allows for this. With the patch, devices will only get
this new behavior if a flag gets set in their scsi_device struct by
the LLD in its slave_configure routine.
-Brian
> On Tue, Feb 17, 2004 at 01:06:00PM +0530, Sachin Mhatre (smhatre) wrote:
>
>>Has this patch been included in the linux 2.6.X kernel? This patch would
>>also help the iscsi LLDD as it is also facing the same START_UNIT
>>problem.
>>I would really appreciate any help on this matter.
>>
>>Thanks,
>>Sachin
>>
>>
>>-----Original Message-----
>>From: linux-scsi-owner@vger.kernel.org
>>[mailto:linux-scsi-owner@vger.kernel.org] On Behalf Of Brian King
>>Sent: Friday, January 30, 2004 3:45 AM
>>To: James.Bottomley@steeleye.com
>>Cc: linux-scsi@vger.kernel.org
>>Subject: [PATCH] Midlayer initiated START_UNIT
>>
>>
>>James,
>>
>>This is a patch to issue a START_UNIT command from the midlayer error
>>handler. The ipr driver, which is currently out for review needs this to
>>function properly. Any time the adapter gets reset, the disk array
>>resources under the ipr adapter require another START_UNIT command. This
>>causes problems with the current error handling and these devices get
>>taken offline when this occurs.
>>
>>This was being handled by the ipr driver itself, but Christoph did not
>>like seeing a LLDD issuing commands to devices, hence the patch.
>>
>>http://marc.theaimsgroup.com/?l=linux-scsi&m=107462193622673&w=2
>>
>>Patch is against 2.6.2-rc2.
>>
>>Thanks
>>
>>
>>
>>--
>>Brian King
>>eServer Storage I/O
>>IBM Linux Technology Center
>>
>>-
>>To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
>>the body of a message to majordomo@vger.kernel.org More majordomo info
>>at http://vger.kernel.org/majordomo-info.html
>>
>>-
>>To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
>>the body of a message to majordomo@vger.kernel.org
>>More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
--
Brian King
eServer Storage I/O
IBM Linux Technology Center
next prev parent reply other threads:[~2004-02-17 14:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-29 22:15 [PATCH] Midlayer initiated START_UNIT Brian King
2004-02-17 7:36 ` Sachin Mhatre (smhatre)
2004-02-17 8:04 ` Matthew Dharm
2004-02-17 14:27 ` Brian King [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-01-26 19:43 Brian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=403224CA.2050107@us.ibm.com \
--to=brking@us.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mdharm-scsi@one-eyed-alien.net \
--cc=smhatre@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.