From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:56602 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1175183AbdDYHWl (ORCPT ); Tue, 25 Apr 2017 03:22:41 -0400 From: Laurent Pinchart To: Wei Yongjun Cc: David Airlie , Wei Yongjun , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH -next] drm/shmob: fix return value check in shmob_drm_probe() Date: Tue, 25 Apr 2017 10:23:42 +0300 Message-ID: <4032906.qIxZEVbvQP@avalon> In-Reply-To: <20170425030808.7632-1-weiyj.lk@gmail.com> References: <20170425030808.7632-1-weiyj.lk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Wei, Thank you for the patch. On Tuesday 25 Apr 2017 03:08:08 Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function devm_ioremap_resource() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check should > be replaced with IS_ERR(). > > Signed-off-by: Wei Yongjun Reviewed-by: Laurent Pinchart and applied to my tree. I'll send a pull request for v4.13. > --- > drivers/gpu/drm/shmobile/shmob_drm_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/shmobile/shmob_drm_drv.c > b/drivers/gpu/drm/shmobile/shmob_drm_drv.c index 800d1d2..6bd777a 100644 > --- a/drivers/gpu/drm/shmobile/shmob_drm_drv.c > +++ b/drivers/gpu/drm/shmobile/shmob_drm_drv.c > @@ -235,8 +235,8 @@ static int shmob_drm_probe(struct platform_device *pdev) > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > sdev->mmio = devm_ioremap_resource(&pdev->dev, res); > - if (sdev->mmio == NULL) > - return -ENOMEM; > + if (IS_ERR(sdev->mmio)) > + return PTR_ERR(sdev->mmio); > > ret = shmob_drm_setup_clocks(sdev, pdata->clk_source); > if (ret < 0) -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH -next] drm/shmob: fix return value check in shmob_drm_probe() Date: Tue, 25 Apr 2017 10:23:42 +0300 Message-ID: <4032906.qIxZEVbvQP@avalon> References: <20170425030808.7632-1-weiyj.lk@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id B20416E2E2 for ; Tue, 25 Apr 2017 07:22:35 +0000 (UTC) In-Reply-To: <20170425030808.7632-1-weiyj.lk@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Wei Yongjun Cc: linux-renesas-soc@vger.kernel.org, Wei Yongjun , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgV2VpLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBUdWVzZGF5IDI1IEFwciAyMDE3 IDAzOjA4OjA4IFdlaSBZb25nanVuIHdyb3RlOgo+IEZyb206IFdlaSBZb25nanVuIDx3ZWl5b25n anVuMUBodWF3ZWkuY29tPgo+IAo+IEluIGNhc2Ugb2YgZXJyb3IsIHRoZSBmdW5jdGlvbiBkZXZt X2lvcmVtYXBfcmVzb3VyY2UoKSByZXR1cm5zIEVSUl9QVFIoKQo+IGFuZCBuZXZlciByZXR1cm5z IE5VTEwuIFRoZSBOVUxMIHRlc3QgaW4gdGhlIHJldHVybiB2YWx1ZSBjaGVjayBzaG91bGQKPiBi ZSByZXBsYWNlZCB3aXRoIElTX0VSUigpLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFdlaSBZb25nanVu IDx3ZWl5b25nanVuMUBodWF3ZWkuY29tPgoKUmV2aWV3ZWQtYnk6IExhdXJlbnQgUGluY2hhcnQg PGxhdXJlbnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4KCmFuZCBhcHBsaWVkIHRvIG15IHRy ZWUuIEknbGwgc2VuZCBhIHB1bGwgcmVxdWVzdCBmb3IgdjQuMTMuCgo+IC0tLQo+ICBkcml2ZXJz L2dwdS9kcm0vc2htb2JpbGUvc2htb2JfZHJtX2Rydi5jIHwgNCArKy0tCj4gIDEgZmlsZSBjaGFu Z2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9zaG1vYmlsZS9zaG1vYl9kcm1fZHJ2LmMKPiBiL2RyaXZlcnMvZ3B1L2Ry bS9zaG1vYmlsZS9zaG1vYl9kcm1fZHJ2LmMgaW5kZXggODAwZDFkMi4uNmJkNzc3YSAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vc2htb2JpbGUvc2htb2JfZHJtX2Rydi5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL3NobW9iaWxlL3NobW9iX2RybV9kcnYuYwo+IEBAIC0yMzUsOCArMjM1 LDggQEAgc3RhdGljIGludCBzaG1vYl9kcm1fcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAq cGRldikKPiAKPiAgCXJlcyA9IHBsYXRmb3JtX2dldF9yZXNvdXJjZShwZGV2LCBJT1JFU09VUkNF X01FTSwgMCk7Cj4gIAlzZGV2LT5tbWlvID0gZGV2bV9pb3JlbWFwX3Jlc291cmNlKCZwZGV2LT5k ZXYsIHJlcyk7Cj4gLQlpZiAoc2Rldi0+bW1pbyA9PSBOVUxMKQo+IC0JCXJldHVybiAtRU5PTUVN Owo+ICsJaWYgKElTX0VSUihzZGV2LT5tbWlvKSkKPiArCQlyZXR1cm4gUFRSX0VSUihzZGV2LT5t bWlvKTsKPiAKPiAgCXJldCA9IHNobW9iX2RybV9zZXR1cF9jbG9ja3Moc2RldiwgcGRhdGEtPmNs a19zb3VyY2UpOwo+ICAJaWYgKHJldCA8IDApCgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hh cnQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=