Re: [PATCH] [2.6] UFS2 Read Only Patch

[Niraj Kumar <niraj17@iitbombay.org>]

Andrew,

I have updated the patch files.

Let me know if you have any more comments.

Niraj

Andrew Morton wrote:

>Niraj Kumar <niraj17@iitbombay.org> wrote:
>  
>
>The patches which you have there are a bit of a disaster coding-style wise.
>
>- Use hard tabs everywhere, not eight-spaces.
>
>- No space before terminating semicolons
>
>-
>
>+        if ( (flags & UFS_TYPE_MASK) == UFS_TYPE_UFS2)
>+        {
>+	     uspi->s_u2_size  = fs64_to_cpu(sb, usb->fs_u11.fs_u2.fs_size);
>
>  should be
>
>	if ((flags & UFS_TYPE_MASK) == UFS_TYPE_UFS2) {
>
>  etcetera.   See Documentation/CodingStyle.
>
>
>Thanks.
>  
>