All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: lartc@vger.kernel.org
Subject: Re: [LARTC] IMQ patch for iptables-1.2.9 and kernel 2.6.2 final !
Date: Fri, 20 Feb 2004 17:16:53 +0000	[thread overview]
Message-ID: <40364105.3060601@trash.net> (raw)
In-Reply-To: <Pine.LNX.4.58.0402191815410.21441@fly-net.ro>

Andre,
thanks for doing this. I also felt like I need to say something for
some time. Roy, you should also stop telling people your version would
be "more stable". IMQ's problems are related to specific setups, so I
don't understand how you can state this without even understanding the
problem. Evidence points to IMQs use of skb->destructor, which means
you'll probably see problems when using IMQ with local tcp/udp traffic.
Your approach of using NF_STOLEN instead of NF_QUEUE seems like a good
idea, but besides beeing butt-ugly your code isn't usable for ingress
traffic, so it's not a replacement for many people. Other bugs probably
exist, I just had a short look.

Patrick

BTW: Not that I would care much, but why did you replace my copyright
with credits for hook registration to Martin ? Martin's version did not
even hook netfilter, it's clearly derived from my version.

Andre Correa wrote:
> 
> Hi, I'm sorry for not being able to be really polite this time, but:
> 
> Roy, can you please STOP telling that egress crashs IMQ!?
> 
> We've discussed it lots of times before, here and at linuximq mailling 
> list and the only known functionality that crashs IMQ (oriinal) is to 
> touch local generated traffic...
> 
> I've being using ingress+egress with IMQ in a server with a great 
> amouunt of traffic, for a long period without any crashs.
> 
> Please don't keep telling something known to be wrong or otherwise 
> proove it so we can fix it...
> 
> tks
> 
> Andre
> 
_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

  parent reply	other threads:[~2004-02-20 17:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-19 16:19 [LARTC] IMQ patch for iptables-1.2.9 and kernel 2.6.2 final ! The Codrinus
2004-02-19 18:28 ` Stef Coene
2004-02-19 19:18 ` The Codrinus
2004-02-20  0:15 ` Roy
2004-02-20  0:56 ` The Codrinus
2004-02-20  1:13 ` Roy
2004-02-20 11:45 ` Andre Correa
2004-02-20 17:16 ` Patrick McHardy [this message]
2004-02-20 18:21 ` Roy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40364105.3060601@trash.net \
    --to=kaber@trash.net \
    --cc=lartc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.