From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:34724 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726872AbeINQTb (ORCPT ); Fri, 14 Sep 2018 12:19:31 -0400 From: Laurent Pinchart To: Kieran Bingham Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] drm: rcar-du: Update Gen3 output limitations Date: Fri, 14 Sep 2018 14:05:44 +0300 Message-ID: <4037354.l5ltzbp0ev@avalon> In-Reply-To: <20180831181259.29529-2-kieran.bingham+renesas@ideasonboard.com> References: <20180831181259.29529-1-kieran.bingham+renesas@ideasonboard.com> <20180831181259.29529-2-kieran.bingham+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Kieran, Thank you for the patch. On Friday, 31 August 2018 21:12:57 EEST Kieran Bingham wrote: > The R-Car Gen3 DU utilises the VSP1 hardware for memory access. The > limits on the RPF and WPF in this pipeline are 8190x8190. > > Update the supported maximum sizes accordingly. > > Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart and applied to my tree. > --- > drivers/gpu/drm/rcar-du/rcar_du_kms.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c > b/drivers/gpu/drm/rcar-du/rcar_du_kms.c index ed7fa3204892..7c7aff8cdf77 > 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > @@ -512,12 +512,22 @@ int rcar_du_modeset_init(struct rcar_du_device *rcdu) > > dev->mode_config.min_width = 0; > dev->mode_config.min_height = 0; > - dev->mode_config.max_width = 4095; > - dev->mode_config.max_height = 2047; > dev->mode_config.normalize_zpos = true; > dev->mode_config.funcs = &rcar_du_mode_config_funcs; > dev->mode_config.helper_private = &rcar_du_mode_config_helper; > > + if (rcdu->info->gen < 3) { > + dev->mode_config.max_width = 4095; > + dev->mode_config.max_height = 2047; > + } else { > + /* > + * The Gen3 DU uses the VSP1 for memory access, and is limited > + * to frame sizes of 8190x8190. > + */ > + dev->mode_config.max_width = 8190; > + dev->mode_config.max_height = 8190; > + } > + > rcdu->num_crtcs = hweight8(rcdu->info->channels_mask); > > ret = rcar_du_properties_init(rcdu); -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 1/3] drm: rcar-du: Update Gen3 output limitations Date: Fri, 14 Sep 2018 14:05:44 +0300 Message-ID: <4037354.l5ltzbp0ev@avalon> References: <20180831181259.29529-1-kieran.bingham+renesas@ideasonboard.com> <20180831181259.29529-2-kieran.bingham+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id D757A6E21D for ; Fri, 14 Sep 2018 11:05:31 +0000 (UTC) In-Reply-To: <20180831181259.29529-2-kieran.bingham+renesas@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Kieran Bingham Cc: David Airlie , linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgS2llcmFuLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBGcmlkYXksIDMxIEF1Z3Vz dCAyMDE4IDIxOjEyOjU3IEVFU1QgS2llcmFuIEJpbmdoYW0gd3JvdGU6Cj4gVGhlIFItQ2FyIEdl bjMgRFUgdXRpbGlzZXMgdGhlIFZTUDEgaGFyZHdhcmUgZm9yIG1lbW9yeSBhY2Nlc3MuIFRoZQo+ IGxpbWl0cyBvbiB0aGUgUlBGIGFuZCBXUEYgaW4gdGhpcyBwaXBlbGluZSBhcmUgODE5MHg4MTkw Lgo+IAo+IFVwZGF0ZSB0aGUgc3VwcG9ydGVkIG1heGltdW0gc2l6ZXMgYWNjb3JkaW5nbHkuCj4g Cj4gU2lnbmVkLW9mZi1ieTogS2llcmFuIEJpbmdoYW0gPGtpZXJhbi5iaW5naGFtK3JlbmVzYXNA aWRlYXNvbmJvYXJkLmNvbT4KClJldmlld2VkLWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50 LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+CgphbmQgYXBwbGllZCB0byBteSB0cmVlLgoKPiAt LS0KPiAgZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9rbXMuYyB8IDE0ICsrKysrKysr KysrKy0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygt KQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2ttcy5j Cj4gYi9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2ttcy5jIGluZGV4IGVkN2ZhMzIw NDg5Mi4uN2M3YWZmOGNkZjc3Cj4gMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3JjYXIt ZHUvcmNhcl9kdV9rbXMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVf a21zLmMKPiBAQCAtNTEyLDEyICs1MTIsMjIgQEAgaW50IHJjYXJfZHVfbW9kZXNldF9pbml0KHN0 cnVjdCByY2FyX2R1X2RldmljZSAqcmNkdSkKPiAKPiAgCWRldi0+bW9kZV9jb25maWcubWluX3dp ZHRoID0gMDsKPiAgCWRldi0+bW9kZV9jb25maWcubWluX2hlaWdodCA9IDA7Cj4gLQlkZXYtPm1v ZGVfY29uZmlnLm1heF93aWR0aCA9IDQwOTU7Cj4gLQlkZXYtPm1vZGVfY29uZmlnLm1heF9oZWln aHQgPSAyMDQ3Owo+ICAJZGV2LT5tb2RlX2NvbmZpZy5ub3JtYWxpemVfenBvcyA9IHRydWU7Cj4g IAlkZXYtPm1vZGVfY29uZmlnLmZ1bmNzID0gJnJjYXJfZHVfbW9kZV9jb25maWdfZnVuY3M7Cj4g IAlkZXYtPm1vZGVfY29uZmlnLmhlbHBlcl9wcml2YXRlID0gJnJjYXJfZHVfbW9kZV9jb25maWdf aGVscGVyOwo+IAo+ICsJaWYgKHJjZHUtPmluZm8tPmdlbiA8IDMpIHsKPiArCQlkZXYtPm1vZGVf Y29uZmlnLm1heF93aWR0aCA9IDQwOTU7Cj4gKwkJZGV2LT5tb2RlX2NvbmZpZy5tYXhfaGVpZ2h0 ID0gMjA0NzsKPiArCX0gZWxzZSB7Cj4gKwkJLyoKPiArCQkgKiBUaGUgR2VuMyBEVSB1c2VzIHRo ZSBWU1AxIGZvciBtZW1vcnkgYWNjZXNzLCBhbmQgaXMgbGltaXRlZAo+ICsJCSAqIHRvIGZyYW1l IHNpemVzIG9mIDgxOTB4ODE5MC4KPiArCQkgKi8KPiArCQlkZXYtPm1vZGVfY29uZmlnLm1heF93 aWR0aCA9IDgxOTA7Cj4gKwkJZGV2LT5tb2RlX2NvbmZpZy5tYXhfaGVpZ2h0ID0gODE5MDsKPiAr CX0KPiArCj4gIAlyY2R1LT5udW1fY3J0Y3MgPSBod2VpZ2h0OChyY2R1LT5pbmZvLT5jaGFubmVs c19tYXNrKTsKPiAKPiAgCXJldCA9IHJjYXJfZHVfcHJvcGVydGllc19pbml0KHJjZHUpOwoKLS0g ClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2RyaS1kZXZlbAo=