All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Banks <gnb@melbourne.sgi.com>
To: Neil Brown <neilb@cse.unsw.edu.au>
Cc: Linux NFS Mailing List <nfs@lists.sourceforge.net>
Subject: Re: [PATCH] SGI 907674: document fsid export option
Date: Tue, 24 Feb 2004 15:07:29 +1100	[thread overview]
Message-ID: <403ACE01.2BBF39D6@melbourne.sgi.com> (raw)
In-Reply-To: 16442.51053.96888.392883@notabene.cse.unsw.edu.au

Neil Brown wrote:
> 
> On Thursday January 29, gnb@melbourne.sgi.com wrote:
> > G'day,
> >
> > This patch against nfs-utils 1.0.6 documents the fsid=num export
> > option.
> 
> Thanks.  I've added a paragraph about the special meaning of fsid=0
> for NFSv4 and committed it to CVS.
> 

Aha, it's embarrassment time.  Since sending the patch I've discovered
that this part

> > +instead of a number derived from the major and minor number of the
> > +block device on which the filesystem is mounted.  Any 32 bit number
> > +can be used, but it must be unique amongst all the exported filesystems.

is wrong; the fsid passes through a dev_t interface and is silently
truncated to 16 bits.  The following fixes my gaffe.  Sorry.


 --- utils/exportfs/exports.man.orig	Tue Feb 24 15:06:35 2004
+++ utils/exportfs/exports.man	Tue Feb 24 15:06:38 2004
@@ -277,7 +277,7 @@
 handle and file attributes used on the wire to be
 .I num
 instead of a number derived from the major and minor number of the
-block device on which the filesystem is mounted.  Any 32 bit number
+block device on which the filesystem is mounted.  Any 16 bit number
 can be used, but it must be unique amongst all the exported filesystems.
 
 This can be useful for NFS failover, to ensure that both servers of


Greg.
-- 
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
I don't speak for SGI.


-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

  reply	other threads:[~2004-02-24  4:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-29  3:48 [PATCH] SGI 907674: document fsid export option Greg Banks
2004-01-29 23:45 ` Greg Banks
2004-02-24  3:39 ` Neil Brown
2004-02-24  4:07   ` Greg Banks [this message]
2004-02-24  4:10     ` Neil Brown
2004-02-24  4:31       ` Greg Banks
2004-02-25  0:04         ` Neil Brown
2004-02-25  0:31           ` Greg Banks
2004-02-25  3:21             ` Neil Brown
2004-02-25  4:39               ` Greg Banks
2004-02-27 11:37               ` Greg Banks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=403ACE01.2BBF39D6@melbourne.sgi.com \
    --to=gnb@melbourne.sgi.com \
    --cc=neilb@cse.unsw.edu.au \
    --cc=nfs@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.