From: Ulrich Drepper <drepper@redhat.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Jakub Jelinek <jakub@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add getdents32t syscall
Date: Thu, 26 Feb 2004 14:29:28 -0800 [thread overview]
Message-ID: <403E7348.60503@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0402261415590.7830@ppc970.osdl.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Linus Torvalds wrote:
> - pre-fill the dirent area with 0xff or something
fill whole temporary buffer allocated by opendir() for every call to
getdents(2)?
You are swapping a bit of additional kernel code for quite a bit of
overhead at every program's runtime.
Yes, you want to keep your code small and tidy, but getdents calls are
frequent and the wasted cycles spent on the memory operations far
outweigh the extra code. In many cases we have to clear a 8k+ buffer
just because getdents fills in 200 bytes.
Plus, the old code, like all compatibility interface, can over time be
grouped together and moved to one side of the kernel so that they don't
disturb the icache.
- --
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
iD8DBQFAPnNI2ijCOnn/RHQRAnynAKDH4GOGnF3ai/7UHdfc7siArOF7fwCePZZP
huZUMCSGIhAM5uw1zgpLSmM=
=YtUt
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2004-02-26 22:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-26 19:38 [PATCH] Add getdents32t syscall Jakub Jelinek
2004-02-26 22:03 ` Randy.Dunlap
2004-02-26 22:15 ` Linus Torvalds
2004-02-26 22:25 ` Linus Torvalds
2004-02-26 22:29 ` Ulrich Drepper [this message]
2004-02-26 23:00 ` Linus Torvalds
2004-02-26 22:32 ` Jakub Jelinek
2004-02-26 23:15 ` Linus Torvalds
2004-02-27 1:33 ` Ulrich Drepper
2004-02-27 6:16 ` Linus Torvalds
2004-02-27 7:05 ` Ulrich Drepper
2004-02-28 23:21 ` Jamie Lokier
2004-02-27 1:46 ` Andreas Dilger
2004-02-27 3:36 ` Theodore Ts'o
2004-02-29 0:25 ` Jamie Lokier
2004-02-27 19:28 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=403E7348.60503@redhat.com \
--to=drepper@redhat.com \
--cc=jakub@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.