From: Jie Luo <luoj@codeaurora.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: hkallweit1@gmail.com, davem@davemloft.net, kuba@kernel.org,
linux@armlinux.org.uk, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, sricharan@codeaurora.org
Subject: Re: [PATCH v1 1/2] net: mdio: Add the reset function for IPQ MDIO driver
Date: Mon, 9 Aug 2021 21:02:55 +0800 [thread overview]
Message-ID: <403a4418-88b4-eb4e-47fd-d75bf6cdccf2@codeaurora.org> (raw)
In-Reply-To: <YQ/4aK3yYPvYQdhD@lunn.ch>
On 8/8/2021 11:29 PM, Andrew Lunn wrote:
>> + /* Configure MDIO clock source frequency if clock is specified in the device tree */
>> + if (!IS_ERR_OR_NULL(priv->mdio_clk)) {
> Please document the clock in the binding. Make it clear which devices
> require the clock, and which don't.
>
> Andrew
sure, will document it in the next patch set, thanks Andrew.
next prev parent reply other threads:[~2021-08-09 13:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-08 7:21 [PATCH v1 0/2] net: mdio: Add IPQ MDIO reset related function Luo Jie
2021-08-08 7:21 ` [PATCH v1 1/2] net: mdio: Add the reset function for IPQ MDIO driver Luo Jie
2021-08-08 15:27 ` Andrew Lunn
2021-08-09 13:01 ` Jie Luo
2021-08-08 15:29 ` Andrew Lunn
2021-08-09 13:02 ` Jie Luo [this message]
2021-08-08 7:21 ` [PATCH v1 2/2] MDIO: Kconfig: Specify more IPQ chipset supported Luo Jie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=403a4418-88b4-eb4e-47fd-d75bf6cdccf2@codeaurora.org \
--to=luoj@codeaurora.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.