All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira <pablo@eurodev.net>
To: Henrik Nordstrom <hno@marasystems.com>,
	netfilter-devel@lists.netfilter.org
Subject: Re: ip_ct_refresh lock issue
Date: Sat, 28 Feb 2004 16:04:26 +0100	[thread overview]
Message-ID: <4040ADFA.4030107@eurodev.net> (raw)
In-Reply-To: <Pine.LNX.4.44.0402281547520.9609-100000@filer.marasystems.com>

Hi henrik,

Henrik Nordstrom wrote:

>But maybe there is some complication from NAT or related connections
>requiring this locking?
>  
>
Actually a quick view at:

http://lxr.linux.no/ident?v=2.6.1&i=ip_ct_refresh

show me that this function is only called from conntrack related stuff, 
specifically from protocol and helpers, so i can't see that complication 
from NAT nor with related connections. Anyway, I'm not sure at all... 
that's why i need some feedback.

>If not the lock should probably be moved down to the is_confirmed case. If
>the connections is not yet confirmed then the only reference should be
>from this packet (not yet in the hashes) and there should never be any
>concurrent accesses.
>  
>
yes, this is exactly what i had in mind :-).

thanks,
Pablo

      reply	other threads:[~2004-02-28 15:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-28 14:18 ip_ct_refresh lock issue Pablo Neira
2004-02-28 14:54 ` Henrik Nordstrom
2004-02-28 15:04   ` Pablo Neira [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4040ADFA.4030107@eurodev.net \
    --to=pablo@eurodev.net \
    --cc=hno@marasystems.com \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.